WIP: Fixing CORS error in genericapiserver #27386
Conversation
|
I think I have a fix but I cant get the test to pass, which obviously means that my fix is not correct. When I run the test, I see that the CORS handler is registered. But it is not called when I send the request. |
k8s-github-robot
added
size/M
nikhiljindal
added
sig/api-machinery
|
GCE e2e build/test passed for commit 27c133b. |
k8s-github-robot
added
do-not-merge
apelisse
removed
the
do-not-merge
|
@nikhiljindal PR needs rebase |
k8s-github-robot
added
the
needs-rebase
|
Since this was listed as a regression, do we need to commit to this for 1.4? |
|
This PR hasn't been active in 90 days. Closing this PR. Please reopen if you would like to work towards merging this change, if/when the PR is ready for the next round of review. cc @nikhiljindal @smarterclayton You can add 'keep-open' label to prevent this from happening again, or add a comment to keep it open another 90 days |
| master, etcdserver, _, _ := newMaster(t) | ||
| defer etcdserver.Terminate(t) | ||
|
|
||
| server := httptest.NewServer(master.HandlerContainer.ServeMux) |
There was a problem hiding this comment.
I think this should be server := httptest.NewServer(master.Handler) or server := httptest.NewServer(master.InsecureHandler)
| t.Fatalf("unexpected error: %v", err) | ||
| } | ||
|
|
||
| if resp.StatusCode != http.StatusOK { |
There was a problem hiding this comment.
In case of an OPTIONS request, we are expecting http.StatusNoContent
Ref #24086
This change is