Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[client-gen]Add Patch to clientset #27293

Merged
merged 1 commit into from
Jun 26, 2016
Merged

[client-gen]Add Patch to clientset #27293

merged 1 commit into from
Jun 26, 2016

Conversation

caesarxuchao
Copy link
Member

@caesarxuchao caesarxuchao commented Jun 13, 2016 •
edited
Loading

  • add the Patch() method to the clientset.
  • I have to rename the existing Patch() method of Event to PatchWithEventNamespace() to avoid overriding.
  • some minor changes to the fake Patch action.

cc @Random-Liu since he asked for the method
@kubernetes/sig-api-machinery

ref #26580

Add the Patch method to the generated clientset.

@caesarxuchao caesarxuchao added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Jun 13, 2016
@k8s-github-robot k8s-github-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. release-note-label-needed labels Jun 13, 2016
@caesarxuchao caesarxuchao changed the title Add Patch to clientset [client-gen]Add Patch to clientset Jun 13, 2016
@Random-Liu
Copy link
Member

@caesarxuchao Thanks~~ :)

@caesarxuchao caesarxuchao force-pushed the add-patch-to-clientset branch 2 times, most recently from d6e8540 to a857eb3 Compare June 13, 2016 23:35
@k8s-github-robot k8s-github-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 13, 2016
@caesarxuchao
Copy link
Member Author 

type checker error: /go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/pkg/client/clientset_generated/release_1_3/typed/core/v1/fake/fake_event_expansion.go:55:22: method Patch already declared for FakeEvents
type checker error: /go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/pkg/client/clientset_generated/release_1_3/typed/core/v1/fake/fake_event.go:109:22:    other declaration of Patch
E0613 16:57:14.553438   16686 main.go:85] Error: Failed making a context: /go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/pkg/client/clientset_generated/release_1_3/typed/core/v1/fake/fake_event_expansion.go:55:22: method Patch already declared for FakeEvents
!!! Error in ./hack/../hack/verify-import-boss.sh:28
  '$(kube::util::find-binary "import-boss") --verify-only' exited with status 1
Call stack:
  1: ./hack/../hack/verify-import-boss.sh:28 main(...)
Exiting with status 1
FAILED   ./hack/../hack/verify-import-boss.sh

seems I have more work to do..

@k8s-github-robot
Copy link

@krousey
You must link to the test flake issue which caused you to request this manual re-test.
Re-test requests should be in the form of: k8s-bot test this issue: #<number>
Here is the list of open test flakes.

@caesarxuchao caesarxuchao force-pushed the add-patch-to-clientset branch from a857eb3 to 5bd0823 Compare June 14, 2016 18:17
@krousey krousey added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 15, 2016
@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 15, 2016
@caesarxuchao caesarxuchao added release-note Denotes a PR that will be considered when it comes time to generate release notes. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed release-note-label-needed labels Jun 16, 2016
@caesarxuchao
Copy link
Member Author

Reapplying the lgtm after satisfying the release note process.

@caesarxuchao caesarxuchao force-pushed the add-patch-to-clientset branch from 5bd0823 to a29f6aa Compare June 17, 2016 17:31
@caesarxuchao
Copy link
Member Author

Squashed. Reapplying the lgtm.

@caesarxuchao caesarxuchao added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jun 17, 2016
@caesarxuchao caesarxuchao mentioned this pull request Jun 20, 2016
Merged
@k8s-bot
Copy link

k8s-bot commented Jun 21, 2016

GCE e2e build/test passed for commit a29f6aa.

@caesarxuchao
Copy link
Member Author

@k8s-bot test this, issue #IGNORE

@k8s-bot
Copy link

k8s-bot commented Jun 24, 2016

GCE e2e build/test passed for commit a29f6aa.

@caesarxuchao caesarxuchao mentioned this pull request Jun 25, 2016
Merged
@0xmichalis 0xmichalis mentioned this pull request Jun 25, 2016
Closed
@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Jun 26, 2016

GCE e2e build/test passed for commit a29f6aa.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 9303784 into kubernetes:master Jun 26, 2016
@caesarxuchao
Copy link
Member Author

The changes affects the release_1_3 clientset, so it should be cherry-picked.. @krousey could you approve the cherry-pick?

@k8s-cherrypick-bot
Copy link

Removing label cherrypick-candidate because no release milestone was set. This is an invalid state and thus this PR is not being considered for cherry-pick to any release branch. Please add an appropriate release milestone and then re-add the label.

@caesarxuchao caesarxuchao added this to the v1.3 milestone Jun 27, 2016
@caesarxuchao
Copy link
Member Author

@roberthbailey could you approve the cherry-pick? Or shall I let @krousey approve it?

@erictune
Copy link
Member

Per conversation with @lavalamp and @caesarxuchao this is not P0, not cherry picking it.

@caesarxuchao caesarxuchao mentioned this pull request Jun 28, 2016
Merged
@eparis eparis removed this from the v1.3 milestone Jun 29, 2016
@caesarxuchao caesarxuchao mentioned this pull request Jul 12, 2016
Merged
k8s-github-robot pushed a commit that referenced this pull request Jul 13, 2016
Merge pull request #28820 from caesarxuchao/patch-subresource
6b6141f 
Automatic merge from submit-queue

[client-gen] Allow passing subresources in Patch method

Expand the Patch() method from:
```
Patch(name string, pt api.PatchType, data []byte)
```
to
```
Patch(name string, pt api.PatchType, data []byte, subresources ...string)
```

Continue on #27293. Fixes #26580.

cc @Random-Liu @lavalamp
@caesarxuchao caesarxuchao deleted the add-patch-to-clientset branch May 12, 2020 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@krousey krousey

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@caesarxuchao @Random-Liu @k8s-github-robot @k8s-bot @k8s-cherrypick-bot @erictune @krousey @googlebot @eparis