Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove known metrics list #27265

Merged
merged 1 commit into from
Jun 17, 2016
Merged

Remove known metrics list #27265

merged 1 commit into from
Jun 17, 2016

Conversation

gmarek
Copy link
Contributor

@gmarek gmarek commented Jun 13, 2016 •
edited by fgrzadkowski
Loading

Fixes #26800

@gmarek gmarek added the release-note-none Denotes a PR that doesn't merit a release note. label Jun 13, 2016
@k8s-github-robot k8s-github-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 13, 2016
@ikehz
Copy link
Contributor

ikehz commented Jun 13, 2016

Is this a fix for #26800? Should we close #26887?

@ikehz ikehz mentioned this pull request Jun 13, 2016
Closed
@ikehz
Copy link
Contributor

ikehz commented Jun 13, 2016

I have pretty much zero context on this; @gmarek is there someone else who'd be a better reviewer?

@gmarek
Copy link
Contributor Author

gmarek commented Jun 14, 2016

I don't think so. We added it to have a list of exposed metrics somewhere, but given the amount of pain it causes I don't think it's worth maintaining.

@ikehz ikehz added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 14, 2016
@ikehz
Copy link
Contributor

ikehz commented Jun 14, 2016

Like I said, zero context, but if there are no better reviewers, LGTM.

@k8s-bot
Copy link

k8s-bot commented Jun 15, 2016

GCE e2e build/test passed for commit 0adcc8e.

@erictune erictune added this to the v1.3 milestone Jun 15, 2016
@erictune erictune added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Jun 17, 2016
@erictune erictune mentioned this pull request Jun 17, 2016
Closed
@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Jun 17, 2016

GCE e2e build/test passed for commit 0adcc8e.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 82ab80c into kubernetes:master Jun 17, 2016
@gmarek gmarek deleted the grabber-test branch August 30, 2016 09:49
@gmarek gmarek mentioned this pull request Sep 20, 2016
Merged
k8s-github-robot pushed a commit that referenced this pull request Sep 27, 2016
Merge pull request #33078 from gmarek/automated-cherry-pick-of-#27265…
93017ed 
…-upstream-release-1.2

Automatic merge from submit-queue

Automated cherry pick of #27265

Fix #32704

Cherry pick of #27265 on release-1.2.

cc @davidopp
@gmarek gmarek mentioned this pull request Sep 28, 2016
Closed
shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request Dec 1, 2016
Merge pull request kubernetes#33078 from gmarek/automated-cherry-pick…
5262ad1 
…-of-#27265-upstream-release-1.2

Automatic merge from submit-queue

Automated cherry pick of kubernetes#27265

Fix kubernetes#32704

Cherry pick of kubernetes#27265 on release-1.2.

cc @davidopp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.
7 participants
@gmarek @ikehz @k8s-bot @k8s-github-robot @googlebot @eparis @erictune