Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump minimum API version for docker to 1.21 #27208

Merged
merged 1 commit into from
Jun 25, 2016
Merged

Bump minimum API version for docker to 1.21 #27208

merged 1 commit into from
Jun 25, 2016

Conversation

yujuhong
Copy link
Contributor

The corresponding docker version is 1.9.x. Dropping support for docker 1.8.

/cc @kubernetes/sig-node

@yujuhong yujuhong added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Jun 10, 2016
@yujuhong yujuhong added this to the v1.3 milestone Jun 10, 2016
@yujuhong yujuhong added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jun 10, 2016
@k8s-github-robot k8s-github-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 10, 2016
@euank
Copy link
Contributor

euank commented Jun 10, 2016

This should require updating the CoreOS version used in the node e2e to the latest of any release channel (preferably stable or alpha) which all have docker 1.10.3 right now.

The node_e2e image currently used is fairly old and has docker v1.8.3.
Hopefully the node_e2e test doesn't miss this :)

cc @pwittrock

@yujuhong
Copy link
Contributor Author

This should require updating the CoreOS version used in the node e2e to the latest of any release channel (preferably stable or alpha) which all have docker 1.10.3 right now.

I thought you were doing that :)

@dchen1107
Copy link
Member

dchen1107 commented Jun 10, 2016 •
edited
Loading

sgtm, but will hold it until node e2e image issues are clean.

@euank
Copy link
Contributor

euank commented Jun 10, 2016

Oh, duh, it's still disabled for this PR so I shouldn't expect it to fail for that reason. Whoops. Regardless, 👍 to holding off until the CoreOS image is updated and reenabled.

Ref: #27167 where it might be updated (but doesn't strictly need to be) and, if it doesn't get updated there, I'll file a new issue specifically for that.

@euank euank mentioned this pull request Jun 10, 2016
Closed
@yujuhong
Copy link
Contributor Author

Ref: #27167 where it might be updated (but doesn't strictly need to be) and, if it doesn't get updated there, I'll file a new issue specifically for that.

Thanks! I wish there was a way to specify dependency for github issues...

@euank euank mentioned this pull request Jun 14, 2016
Closed
@goltermann
Copy link
Contributor

Is the Core OS version updated? Can we get this LGTMed and in?

@yujuhong
Copy link
Contributor Author

Is the Core OS version updated? Can we get this LGTMed and in?

Not yet. #27383 is still open.

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 22, 2016
@yujuhong
Bump minimum API version for docker to 1.21
07b8c61 
The corresponding docker version is 1.9.x. Dropping support for docker 1.8.
@yujuhong yujuhong force-pushed the min_docker_version branch from e4fe336 to 07b8c61 Compare June 23, 2016 17:22
@yujuhong
Copy link
Contributor Author

Trivial rebase. Ready to go once #27913 is merged.

PTAL.

@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 23, 2016
@k8s-bot
Copy link

k8s-bot commented Jun 23, 2016

GCE e2e build/test passed for commit 07b8c61.

@euank
Copy link
Contributor

euank commented Jun 23, 2016

LGTM pending that issue.

@yujuhong
Copy link
Contributor Author

@k8s-bot node e2e test this issue: #IGNORE

@idvoretskyi
Copy link
Member

The corresponding issue is merged. Can we go ahead and merge this one?

@yujuhong
Copy link
Contributor Author 

Jun 24 01:07:20.722: INFO: Condition Ready of node tmp-node-e2e-50a04a7a-e2e-node-ubuntu-trusty-docker8-image is false instead of true. Re

We need to drop ubuntu docker 8 image.

@yujuhong
Copy link
Contributor Author

Blocked on #28031

@yujuhong
Copy link
Contributor Author

@k8s-bot node e2e test this issue: #IGNORE

@yujuhong
Copy link
Contributor Author

Anyone wants to LGTM the PR? :-|

@yujuhong
Copy link
Contributor Author

I found one in the previous comment #27208 (comment)
applying the label.

@yujuhong yujuhong added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 24, 2016
@yifan-gu
Copy link
Contributor

LGTM

@yujuhong yujuhong mentioned this pull request Jun 24, 2016
Merged
@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Jun 25, 2016

GCE e2e build/test passed for commit 07b8c61.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 6f8a0c6 into kubernetes:master Jun 25, 2016
@erictune erictune added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 25, 2016
@eparis eparis mentioned this pull request Jun 27, 2016
Merged
eparis pushed a commit to eparis/kubernetes that referenced this pull request Jun 29, 2016
@eparis
Merge pull request kubernetes#27208 from yujuhong/min_docker_version
1433e64 
Automatic merge from submit-queue

Bump minimum API version for docker to 1.21

The corresponding docker version is 1.9.x. Dropping support for docker 1.8.

/cc @kubernetes/sig-node
(cherry picked from commit 6f8a0c6)
@Random-Liu Random-Liu mentioned this pull request Jun 29, 2016
Merged
k8s-github-robot pushed a commit that referenced this pull request Jun 29, 2016
Merge pull request #28119 from eparis/release-1.3
28925df 
Automatic merge from submit-queue

Batch update for 1.3

#28030: Revert "Federation e2e supports aws"
#28026: Address outstanding review comments in #27999.
#28034: Adding lock files for kubeconfig updating
#28004: return nil from NewClientConfig instead of empty struct
#28032: Increase pod CPU/memory for fluentd, dns and kube-proxy.
#27208: Bump minimum API version for docker to 1.21
#28061: Remove extra double quotes in --federations.
#28060: rkt: Fix the 'privileged' check when stage1 annotation is provided.
#27996: Image GC logic should compensate for reserved blocks
#28044: rkt: Bump required rkt version to 1.9.1.
#28040: Tracked addition of federation, sed support in kube DNS
#28043: Set grace period to 0 when deleting namespaces after the test.
#28002: Fix startup type error in initializeCaches
#28087: Hotfix: Fixup the hyperkube dns manifest from a breaking federation PR
#28108: Fix initialization of volume controller caches.
#28056: Increase kube-dns requirements on CoreOS.
#28147: Fix error checks after cloning.
#28159: Use : as seccomp security option operator for Docker 1.10
#28165: Refactored, expanded and fixed federated-services e2e tests.
#28095: Kubelet should mark VolumeInUse before checking if it is Attached
#28172: Build: Add KUBE_GCS_RELEASE_BUCKET_MIRROR option to push-ci-build.sh
#28207: Bump cluster autoscaler to 0.2.2
#28160: Volume manager must verify containers terminated before deleting for ungracefully terminated pods
#28211: Fix federation e2e tests by correctly managing cluster clients
#27944: Fix pvc label selector validation error
#28186: federation: Upgrading the groupversion to v1beta1
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.3" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

k8s-github-robot pushed a commit that referenced this pull request Jul 1, 2016
Merge pull request #28240 from Random-Liu/add-semver-back
9470bfd 
Automatic merge from submit-queue

Kubelet: Add the docker semver back.

Fixes #28221.
This PR:
1) Add the semver back #20020
2) Remove the code in #20827, because docker 1.8 is not officially supported now, and we want to deprecate it. #27208
3) Add a test for docker version comparison.

XRef #28223

@yujuhong 
/cc @ingvagabund 

[![Analytics](https://kubernetes-site.appspot.com/UA-36037335-10/GitHub/.github/PULL_REQUEST_TEMPLATE.md?pixel)]()
@yujuhong yujuhong deleted the min_docker_version branch July 22, 2016 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dchen1107 dchen1107

Labels
cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.