Add support for TAP (test anything protocol) output #2720
Conversation
| TestKubernetesROService, | ||
| TestKubeletSendsEvent, | ||
| tests := []TestSpec{ | ||
| {TestKubernetesROService, "TestKubernetesROService", 1}, |
There was a problem hiding this comment.
Do we really have to specify an index? can't that be figured out by using a loop variable or something?
There was a problem hiding this comment.
I would like to specify an index so that the index of a test stays consistent, even if someone adds a test in the middle of the list.
--brendan
There was a problem hiding this comment.
In that case, please add a comment explaining why you want that (what's wrong with name??), and maybe find a better name than "index", because no one is going to assume you want the indexes to get mixed up over time...
|
Rebased. PTAL |
brendandburns
force-pushed
the
tap
branch
2 times, most recently
from
d81410b to
c7db724
Compare
|
Passes e2e... |
|
Github hid my last comment because it was a response: "please add a comment explaining why you want [indexes to behave like that], and maybe find a better name than "index", because no one is going to assume you want the indexes to get mixed up over time..." |
|
Done. ptal. thanks |
brendandburns
force-pushed
the
tap
branch
2 times, most recently
from
c78c2ea to
a2bc38f
Compare
|
pingity ping ping ;) |
|
LGTM |
Add support for TAP (test anything protocol) output
No description provided.