federation: Adding dnsprovider flags to federation-controller-manager #27158
+61
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @quinton-hoole @kubernetes/sig-cluster-federation |
nikhiljindal
added
release-note
k8s-github-robot
added
kind/old-docs
size/M
|
LGTM! Thanks @nikhiljindal |
ghost
added
the
lgtm
nikhiljindal
force-pushed
the
dnsProvider
branch
from
61ebddc to
45c95b4
Compare
k8s-github-robot
removed
the
lgtm
nikhiljindal
force-pushed
the
dnsProvider
branch
from
45c95b4 to
beda4b0
Compare
|
Updated the bring up script to set DNS_PROVIDER as per KUBERNETES_PROVIDER if its empty. |
k8s-github-robot
added
the
needs-rebase
ghost
added
the
lgtm
|
@nikhiljindal, boilderplate comment needs fixing... |
nikhiljindal
force-pushed
the
dnsProvider
branch
from
beda4b0 to
7efff12
Compare
k8s-github-robot
removed
lgtm
nikhiljindal
force-pushed
the
dnsProvider
branch
from
7efff12 to
3f3a2c1
Compare
|
Rebased and fixed the boilerplate. |
ghost
added
the
lgtm
|
Re-applied LGTM. |
ghost
added
the
priority/important-soon
|
@quinton-hoole why this is P1? |
|
@piosz I elevated it it to P1 as it's blocking today's release branch for 1.3. My apologies, I should have added a comment when I did that. |
|
@quinton-hoole there is >30 PRs in submit queue with milestone 1.3 which basically means that all of them are blockers for today's release. |
|
GCE e2e build/test passed for commit 3f3a2c1. |
|
Automatic merge from submit-queue |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.