Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename ENABLE_NODE_AUTOSCALER to ENABLE_CLUSTER_AUTOSCALER - part 2 #27117

Merged
merged 1 commit into from
Jun 10, 2016
Merged

Rename ENABLE_NODE_AUTOSCALER to ENABLE_CLUSTER_AUTOSCALER - part 2 #27117

merged 1 commit into from
Jun 10, 2016

Conversation

mwielgus
Copy link
Contributor

@mwielgus mwielgus commented Jun 9, 2016 •
edited by fgrzadkowski
Loading

Follow up of #26993

cc: @fgrzadkowski @piosz @jszczepkowski

Rename environment variables (KUBE_)ENABLE_NODE_AUTOSCALER to (KUBE_)ENABLE_CLUSTER_AUTOSCALER.

Fixes #26343

@mwielgus mwielgus added release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. labels Jun 9, 2016
@mwielgus mwielgus added this to the v1.3 milestone Jun 9, 2016
@k8s-github-robot k8s-github-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 9, 2016
@piosz
Copy link
Member

piosz commented Jun 9, 2016

LGTM

@piosz piosz added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 9, 2016
@k8s-bot
Copy link

k8s-bot commented Jun 9, 2016

GCE e2e build/test passed for commit 8b09074.

@fgrzadkowski
Copy link
Contributor

LGTM

Thanks for cleaning this up!

@mwielgus mwielgus added e2e-not-required priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Jun 10, 2016
@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Jun 10, 2016

GCE e2e build/test passed for commit 8b09074.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 447ce33 into kubernetes:master Jun 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@piosz piosz

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.
6 participants
@mwielgus @piosz @k8s-bot @fgrzadkowski @k8s-github-robot @googlebot