Updating e2e docs with instructions on running federation tests #27072

colhom · 2016-06-08T20:07:33Z

Last two commits are for review. Depends on #26951

\cc @madhusudancs @quinton-hoole @nikhiljindal

k8s-bot · 2016-06-08T20:07:47Z

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

k8s-bot · 2016-06-08T20:08:13Z

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

k8s-bot · 2016-06-08T20:08:36Z

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

nikhiljindal · 2016-06-08T20:20:16Z

ok to test

nikhiljindal · 2016-06-08T20:34:03Z

Added the release note label and updated the title accordingly

nikhiljindal · 2016-06-08T20:35:27Z

@colhom Is it possible to remove dependency on #26951?
That way will be able to merge this PR independently.

nikhiljindal · 2016-06-08T20:35:41Z

cc @kubernetes/sig-cluster-federation

colhom · 2016-06-08T21:46:33Z

@nikhiljindal dependency has been removed with some minor re-wording.

colhom · 2016-06-08T21:47:12Z

I was thinking I would squash this in two commits. one separating out the federation image push logic, the second with the docs additions

nikhiljindal · 2016-06-08T23:17:12Z

docs/devel/e2e-tests.md

+
+* You can quickly recompile the e2e testing framework via `go install ./test/e2e`. This will not do anything besides allow you to verify that the go code compiles.
+
+* If you want to run your run e2e testing framework, you can do so via `make WHAT=test/e2e/e2e.test` and then re-running the ginkgo tests.


run your run -> run your?

nikhiljindal · 2016-06-08T23:19:06Z

Yes squashing to 2 commits sg.

Also you need to run the standard scripts to regenerate the TOC in this doc (unit tests are failing)

colhom · 2016-06-09T17:39:00Z

@nikhiljindal review items have been addressed.

nikhiljindal · 2016-06-09T19:46:16Z

docs/devel/e2e-tests.md

+
+* **If `KUBERNETES_PROVIDER=gce` or `KUBERNETES_PROVIDER=gke`**:
+
+	You can simply set your push repo base based on your project name, and the necessary repositorieswill be auto-created when you


repositories will

nikhiljindal · 2016-06-09T22:04:59Z

build/push-federation-images.sh

+
+source "${KUBE_ROOT}/federation/cluster/common.sh"
+
+FEDERATION_IMAGE_TAG="$(kube::release::semantic_image_tag_version)" push-federated-images


sorry for being picky, but while you are at it, will be great if you can rename "push-federated-images" to push-federation-images" :)

colhom · 2016-06-09T22:13:49Z

@nikhiljindal picky nits have been addressed ;) All squashed up.

nikhiljindal · 2016-06-09T22:21:46Z

hack/e2e-internal/e2e-up.sh

@@ -36,14 +36,14 @@ if [[ "${FEDERATION:-}" == "true" ]];then
    # select each one and call federated-up


fix this to say federation-up

nikhiljindal · 2016-06-09T22:24:22Z

Few nits, which are fine to be fixed in another PR.
Adding LGTM label.
Thanks!

k8s-bot · 2016-06-09T23:11:49Z

GCE e2e build/test passed for commit 5f7c7ad.

k8s-github-robot · 2016-06-10T02:14:11Z

Automatic merge from submit-queue

kshafiee · 2016-09-27T19:01:18Z

@colhom I created a repo on quay.io and I am trying to push-federation-images.sh using FEDERATION_PUSH_REPO_BASE="quay.io/kshafiee/kshafiee"
On my build machine I used "docker login quay.io" to login.
Any ideas why I keep getting "error parsing HTTP 400 response body: invalid character '<' ..." ?

colhom · 2016-09-27T20:33:28Z

@kshafiee can you run build/push-federation-images.sh and paste in what you get? At least theoretically, if you did docker login successfully with quay, this should work.

kshafiee · 2016-09-27T21:08:32Z

Thanks @colhom
ubuntu@ubuntu:/work/src/k8s.io/kubernetes$ docker login quay.io
Username (kshafiee):
Password:
Login Succeeded
ubuntu@ubuntu:/work/src/k8s.io/kubernetes$ echo $FEDERATION_PUSH_REPO_BASE
quay.io/kshafiee/kshafiee
ubuntu@ubuntu:~/work/src/k8s.io/kubernetes$ build/push-federation-images.sh
Flag shorthand -c has been deprecated, please use --client instead.
Load: build/../build/../cluster/../cluster/gce/../../cluster/gce/../../cluster/../cluster/../_output/release-stage/server/linux-amd64/kubernetes/server/bin/federation-apiserver.tar
2e70bd6b8087: Loading layer [==================================================>] 125.9 MB/125.9 MB
Tag: gcr.io/google_containers/federation-apiserver:e574d9c3bee434959927ec8d30994870 --> quay.io/kshafiee/kshafiee/federation-apiserver:v1.4.0-alpha.2.1193_febe9adcf0ebd0-dirty
Warning: '-f' is deprecated, it will be removed soon. See usage.
Push: quay.io/kshafiee/kshafiee/federation-apiserver:v1.4.0-alpha.2.1193_febe9adcf0ebd0-dirty
The push refers to a repository [quay.io/kshafiee/kshafiee/federation-apiserver]
2e70bd6b8087: Preparing
5f70bf18a086: Preparing
1834950e52ce: Preparing
error parsing HTTP 400 response body: invalid character '<' looking for beginning of value: "\n<title>400 Bad Request</title>\n

Bad Request

\n

The browser (or proxy) sent a request that this server could not understand.

\n"

colhom · 2016-09-27T21:15:29Z

What docker version do you have?

On Sep 27, 2016 5:09 PM, "kshafiee" notifications@github.com wrote:

Thanks @colhom https://github.com/colhom
ubuntu@ubuntu:/work/src/k8s.io/kubernetes$ docker login quay.io
Username (kshafiee):
Password:
Login Succeeded
ubuntu@ubuntu:/work/src/k8s.io/kubernetes$ echo
$FEDERATION_PUSH_REPO_BASE
quay.io/kshafiee/kshafiee
ubuntu@ubuntu:~/work/src/k8s.io/kubernetes$ build/push-federation-images.
sh
Flag shorthand -c has been deprecated, please use --client instead.
Load: build/../build/../cluster/../cluster/gce/../../cluster/gce/
../../cluster/../cluster/../_output/release-stage/server/
linux-amd64/kubernetes/server/bin/federation-apiserver.tar
2e70bd6b8087: Loading layer [==================================================>]
125.9 MB/125.9 MB
Tag: gcr.io/google_containers/federation-apiserver:
e574d9c3bee434959927ec8d30994870 --> quay.io/kshafiee/kshafiee/
federation-apiserver:v1.4.0-alpha.2.1193_febe9adcf0ebd0-dirty
Warning: '-f' is deprecated, it will be removed soon. See usage.
Push: quay.io/kshafiee/kshafiee/federation-apiserver:v1.4.0-
alpha.2.1193_febe9adcf0ebd0-dirty
The push refers to a repository [quay.io/kshafiee/kshafiee/
federation-apiserver]
2e70bd6b8087: Preparing
5f70bf18a086: Preparing
1834950e52ce: Preparing
error parsing HTTP 400 response body: invalid character '<' looking for
beginning of value: "\n400 Bad Request\n
Bad Request\n

The browser (or proxy) sent a request that this server could not
understand.
\n"

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#27072 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABBnVAemH4a_XXHl4rQbwNv8beDFutC_ks5quYYIgaJpZM4IxWO_
.

kshafiee · 2016-09-27T21:18:26Z

@colhom I'm using:
Version: 1.11.2
API version: 1.23
Go version: go1.5.4

colhom · 2016-09-28T22:20:10Z

@kshafiee so sorry, I did not read your original comment carefully.

FEDERATION_PUSH_REPO_BASE="quay.io/kshafiee/kshafiee"

This should be:

FEDERATION_PUSH_REPO_BASE="quay.io/kshafiee"

federation image repo docs

@madhusudancs

Automatic merge from submit-queue Updating e2e docs with instructions on running federation tests Last two commits are for review. Depends on kubernetes#26951 \cc @madhusudancs @quinton-hoole @nikhiljindal [![Analytics](https://kubernetes-site.appspot.com/UA-36037335-10/GitHub/.github/PULL_REQUEST_TEMPLATE.md?pixel)]()

googlebot added the cla: yes label Jun 8, 2016

k8s-github-robot assigned brendandburns Jun 8, 2016

k8s-github-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note-label-needed labels Jun 8, 2016

nikhiljindal assigned nikhiljindal and ghost and unassigned brendandburns Jun 8, 2016

nikhiljindal added the area/cluster-federation label Jun 8, 2016

nikhiljindal added this to the v1.3 milestone Jun 8, 2016

nikhiljindal added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jun 8, 2016

nikhiljindal changed the title ~~Federation e2e docs~~ Updating e2e docs with instructions on running federation tests Jun 8, 2016

nikhiljindal removed the release-note-label-needed label Jun 8, 2016

extract federation image push from push-ci-build.sh

782bf6e

colhom force-pushed the federation-e2e-docs branch from ce97237 to 546fde3 Compare June 8, 2016 21:45

nikhiljindal reviewed Jun 8, 2016
View reviewed changes

nikhiljindal reviewed Jun 9, 2016
View reviewed changes

colhom force-pushed the federation-e2e-docs branch from 67cc9e9 to d1be7fb Compare June 9, 2016 22:02

nikhiljindal reviewed Jun 9, 2016
View reviewed changes

colhom force-pushed the federation-e2e-docs branch from d1be7fb to 83907c7 Compare June 9, 2016 22:06

document federation e2e cli flow

5f7c7ad

colhom force-pushed the federation-e2e-docs branch from 83907c7 to 5f7c7ad Compare June 9, 2016 22:12

nikhiljindal reviewed Jun 9, 2016
View reviewed changes

nikhiljindal unassigned ghost Jun 9, 2016

nikhiljindal added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 9, 2016

nikhiljindal added the retest-not-required label Jun 10, 2016

k8s-github-robot merged commit 6a388d4 into kubernetes:master Jun 10, 2016

colhom deleted the federation-e2e-docs branch September 27, 2016 20:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updating e2e docs with instructions on running federation tests #27072

Updating e2e docs with instructions on running federation tests #27072

colhom commented Jun 8, 2016 •

edited

Loading

k8s-bot commented Jun 8, 2016

k8s-bot commented Jun 8, 2016

k8s-bot commented Jun 8, 2016

nikhiljindal commented Jun 8, 2016

nikhiljindal commented Jun 8, 2016

nikhiljindal commented Jun 8, 2016

nikhiljindal commented Jun 8, 2016

colhom commented Jun 8, 2016

colhom commented Jun 8, 2016

nikhiljindal Jun 8, 2016

nikhiljindal commented Jun 8, 2016

colhom commented Jun 9, 2016

nikhiljindal Jun 9, 2016

nikhiljindal Jun 9, 2016

colhom commented Jun 9, 2016 •

edited

Loading

nikhiljindal Jun 9, 2016

nikhiljindal commented Jun 9, 2016

k8s-bot commented Jun 9, 2016

k8s-github-robot commented Jun 10, 2016

kshafiee commented Sep 27, 2016 •

edited

Loading

colhom commented Sep 27, 2016

kshafiee commented Sep 27, 2016 •

edited

Loading

colhom commented Sep 27, 2016

kshafiee commented Sep 27, 2016

colhom commented Sep 28, 2016


		* You can quickly recompile the e2e testing framework via `go install ./test/e2e`. This will not do anything besides allow you to verify that the go code compiles.

		* If you want to run your run e2e testing framework, you can do so via `make WHAT=test/e2e/e2e.test` and then re-running the ginkgo tests.


		* If `KUBERNETES_PROVIDER=gce` or `KUBERNETES_PROVIDER=gke`:

		You can simply set your push repo base based on your project name, and the necessary repositorieswill be auto-created when you


		source "${KUBE_ROOT}/federation/cluster/common.sh"

		FEDERATION_IMAGE_TAG="$(kube::release::semantic_image_tag_version)" push-federated-images

		@@ -36,14 +36,14 @@ if [[ "${FEDERATION:-}" == "true" ]];then
		# select each one and call federated-up

Updating e2e docs with instructions on running federation tests #27072

Updating e2e docs with instructions on running federation tests #27072

Conversation

colhom commented Jun 8, 2016 • edited Loading

k8s-bot commented Jun 8, 2016

k8s-bot commented Jun 8, 2016

k8s-bot commented Jun 8, 2016

nikhiljindal commented Jun 8, 2016

nikhiljindal commented Jun 8, 2016

nikhiljindal commented Jun 8, 2016

nikhiljindal commented Jun 8, 2016

colhom commented Jun 8, 2016

colhom commented Jun 8, 2016

nikhiljindal Jun 8, 2016

Choose a reason for hiding this comment

nikhiljindal commented Jun 8, 2016

colhom commented Jun 9, 2016

nikhiljindal Jun 9, 2016

Choose a reason for hiding this comment

nikhiljindal Jun 9, 2016

Choose a reason for hiding this comment

colhom commented Jun 9, 2016 • edited Loading

nikhiljindal Jun 9, 2016

Choose a reason for hiding this comment

nikhiljindal commented Jun 9, 2016

k8s-bot commented Jun 9, 2016

k8s-github-robot commented Jun 10, 2016

kshafiee commented Sep 27, 2016 • edited Loading

colhom commented Sep 27, 2016

kshafiee commented Sep 27, 2016 • edited Loading

Bad Request

colhom commented Sep 27, 2016

kshafiee commented Sep 27, 2016

colhom commented Sep 28, 2016

colhom commented Jun 8, 2016 •

edited

Loading

colhom commented Jun 9, 2016 •

edited

Loading

kshafiee commented Sep 27, 2016 •

edited

Loading

kshafiee commented Sep 27, 2016 •

edited

Loading