@smarterclayton @ironcladlou this is so we can have more meaningful logs in the deployer pod. Currently all update errors (except invalid) are retried and eventually the poller times out and returns a non-sensical message to the user ("timed out waiting for the condition"). Does it make sense to retry only on 409? Can you think of another rc update failure where we want the deployer to keep trying?

GCE e2e build/test passed for commit c7140b3.

• Build Log
• Test Artifacts
• Internal Jenkins Results

I would only expect to retry on 409, and maybe temporary network errors, but that's it.

@janetkuo can you review this when you have free time? I would like it merged as soon as the code freeze is over (got any dates?).

Adding P2 since it's needed for debugging #28067 which is also P2.

Bumping to P0, following the issue priority

Hm, the flake is not related to the scaler, dropping to P2

@Kargakis I am on vacation but will try to review this in the next week or 2

I've got it. LGTM.

Does the default scale implementation for RC / D use patch on the underlying resource? Or not, because we don't have preconditions?

@smarterclayton Thanks

GCE e2e build/test failed for commit c7140b3.

• Test Results
• Build Log
• Test Artifacts
• Internal Jenkins Results

Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake.

@k8s-bot test this issue: #IGNORE

GCE e2e build/test passed for commit c7140b3.

• Test Results
• Build Log
• Test Artifacts
• Internal Jenkins Results

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

GCE e2e build/test passed for commit c7140b3.

• Test Results
• Build Log
• Test Artifacts
• Internal Jenkins Results

GCE e2e build/test passed for commit c7140b3.

• Test Results
• Build Log
• Test Artifacts
• Internal Jenkins Results

Automatic merge from submit-queue

Does the default scale implementation for RC / D use patch on the underlying resource? Or not, because we don't have preconditions?

Full updates, I guess because of preconditions