Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

ok to test

LGTM

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

ok to test

@apelisse @fejta @ixdy @rmmh Is there a way to (a) make those "ok to test" messages notify the assignee and (b) add a needs-ok-to-test label?

@chrislovecnm Does this still need to be fixed, or can it be closed?

@bgrant0607 not within the plugin itself, no. at least not without writing the Java to do so.

@bgrant0607 Sorry for not acknowledging before, but this is definitely on my todo list. Because it's done through the plugin, it's not a "5 minutes fix" unfortunately. But yes, I will try to fix that somehow (as soon as I have time).

@bgrant0607 yes this should go through it is broken on master.

@wfhartford the documentation includes the daemonset, I believe. Please update the docs as well.

@wfhartford The Cassandra example moved to examples/storage/. Can you update the PR?

Also @wfhartford please update the typo in the docs as well https://github.com/kubernetes/kubernetes/blob/master/examples/storage/cassandra/README.md#step-5-use-a-daemonset-instead-of-a-replication-controller

@jeffmendoza we gotta have that done as well.

I seem to have messed something up with the pull request when I rebased. Git is not my native language, sorry. Can anyone enlighten me on what I might have done wrong? If its easiest, I can just create a new PR.

Ah, looks like a merge, try "git rebase origin/master" assuming origin is the upstream repo.

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

CLAs look good, thanks!

GCE e2e build/test passed for commit a9162ed.

• Test Results
• Build Log
• Test Artifacts
• Internal Jenkins Results

That looks a little better. Thanks @jeffmendoza

LGTM

@jeffmendoza @smarterclayton @bprashanth this is also fixed via #30577 ... which one do we want in?

Automatic merge from submit-queue

which one do we want in?

Whichever gets in first