AWS: support mixed plaintext/encrypted ports in ELBs via service.beta.kubernetes.io/aws-load-balancer-ssl-ports annotation #26976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinsb
added
the
priority/important-soon
|
Marking as P1 because without this you can't mix HTTP and HTTPS on a single service with Type=LoadBalancer with our new SSL support, which seems like a very common use-case |
k8s-github-robot
added
size/M
1 similar comment
Fixes kubernetes#26268 Implements the second SSL ELB annotation, per kubernetes#24978 service.beta.kubernetes.io/aws-load-balancer-ssl-ports=* (or e.g. https) If not specified, all ports are secure (SSL or HTTPS).
|
GCE e2e build/test passed for commit 4ff9e93. |
| // getPortSets returns a portSets structure representing port names and numbers | ||
| // that the comma-separated string describes. If the input is empty or equal to | ||
| // "*", a nil pointer is returned. | ||
| func getPortSets(annotation string) (ports *portSets) { |
There was a problem hiding this comment.
Nit: we tend to avoid the named-retval style. But I'm just repeating what I've been told!
|
Some style nits, but nothing we can't fix later (mostly just "for next time" type things) Marking LGTM - thanks for this! |
justinsb
added
the
lgtm
justinsb
changed the title
justinsb
added
release-note
|
(Not sure about whether that release-note name is going to be too long...) |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test passed for commit 4ff9e93. |
|
Automatic merge from submit-queue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26268
Implements the second SSL ELB annotation, per #24978
service.beta.kubernetes.io/aws-load-balancer-ssl-ports=*(comma-separated list of port numbers or e.g.https)If not specified, all ports are secure (SSL or HTTPS).