Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResourceQuota BestEffort scope aligned with Pod level QoS #26969

Merged
merged 1 commit into from
Jun 12, 2016

Conversation

derekwaynecarr
Copy link
Member

@derekwaynecarr derekwaynecarr commented Jun 7, 2016

This aligns quota with the changes in kubelet and CLI.

So if quota allows 10 BestEffort pods, it will now track properly with what the user sees with changes in 1.3.

apiVersion: v1
kind: ResourceQuota
metadata:
  name: best-effort
spec:
  hard:
    pods: "10"
  scopes:
  - BestEffort

/cc @vishh @kubernetes/rh-cluster-infra

@derekwaynecarr derekwaynecarr added this to the v1.3 milestone Jun 7, 2016
@derekwaynecarr derekwaynecarr added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jun 7, 2016
@k8s-github-robot k8s-github-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 7, 2016
}
}
return false
return util.GetPodQos(pod) == util.BestEffort
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Newbie question : GetPodQos seems to return either Burstable or Guaranteed or BestEffort. So here we look for an exact match for util.BestEffort? (in other words, does ResourceQuotaScopeBestEffort, should it be matched with both Guaranteed and BestEffort)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kubernetes/website#622

This is an advanced feature of resourcequota. See step 5 in PR above that discusses scopes filtering the set of resources a quota tracks in an example.

Full doc on scopes and quota:
kubernetes/website#620

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vishh vishh assigned vishh and unassigned brendandburns Jun 7, 2016
@vishh
Copy link
Contributor

vishh commented Jun 7, 2016

LGTM

@vishh vishh added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 7, 2016
@vishh vishh changed the title ResourceQuota BestEffort scope aligned with QoS changes ResourceQuota BestEffort scope aligned with Pod level QoS Jun 7, 2016
@yujuhong
Copy link
Contributor

yujuhong commented Jun 7, 2016

@k8s-bot node e2e test this issue: #26431

@k8s-bot
Copy link

k8s-bot commented Jun 11, 2016

GCE e2e build/test passed for commit f796cc3.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Jun 12, 2016

GCE e2e build/test passed for commit f796cc3.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 49a0475 into kubernetes:master Jun 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants