-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ResourceQuota BestEffort scope aligned with Pod level QoS #26969
ResourceQuota BestEffort scope aligned with Pod level QoS #26969
Conversation
} | ||
} | ||
return false | ||
return util.GetPodQos(pod) == util.BestEffort |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Newbie question : GetPodQos seems to return either Burstable or Guaranteed or BestEffort. So here we look for an exact match for util.BestEffort? (in other words, does ResourceQuotaScopeBestEffort, should it be matched with both Guaranteed and BestEffort)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an advanced feature of resourcequota. See step 5 in PR above that discusses scopes filtering the set of resources a quota tracks in an example.
Full doc on scopes and quota:
kubernetes/website#620
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @derekwaynecarr
LGTM |
GCE e2e build/test passed for commit f796cc3. |
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
GCE e2e build/test passed for commit f796cc3. |
Automatic merge from submit-queue |
This aligns quota with the changes in kubelet and CLI.
So if quota allows 10
BestEffort
pods, it will now track properly with what the user sees with changes in 1.3./cc @vishh @kubernetes/rh-cluster-infra