-
Notifications
You must be signed in to change notification settings - Fork 40.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
godep bump: github.com/evanphx/json-patch #26968
godep bump: github.com/evanphx/json-patch #26968
Conversation
Unrelated flake - |
looks like a dupe of #25866 which should we take? Do we need for 1.3? |
Sorry didn't see the other PR. They're both just bumps of json-patch, this one latest version which includes a fix for rfc 6901 compliant encoded property paths, fixing #26890. I'd take this one. |
And yes I would say this is a good candidate for 1.3 as it's a bug that prevents rfc compliant json patch requests from being handled correctly. |
Sorry this needs another bump after evanphx/json-patch#28 is merged - missed another possible path encoding. |
@jimmidyson json-patch has been updated |
56af7cf
to
fcb54cc
Compare
fcb54cc
to
0aec53a
Compare
@k8s-bot node test this issue #IGNORE it looks like it passed, but maybe didn't report results? |
Hmm again tests seemed to pass but no feedback into Github PR status - any ideas @eparis? |
@ixdy can you help figure out what's up with Node e2e or tell us who could? |
@spxtr maybe you know how to help or what up with the node e2e |
cc @fejta |
Any ideas on why this isn't reporting back? |
Yes, it didn't run because the trigger phrase is: |
@k8s-bot node e2e test this issue #IGNORE |
Doesn't explain what happened the first time, but thanks. |
GCE e2e build/test passed for commit 0aec53a. |
Automatic merge from submit-queue |
Fixes #26890