Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

godep bump: github.com/evanphx/json-patch #26968

Merged

Conversation

jimmidyson
Copy link
Member

Fixes #26890

@jimmidyson
Copy link
Member Author

Unrelated flake - [Fail] [k8s.io] Kubelet metrics api when querying /stats/summary [It] it should report resource usage through the stats api

@eparis
Copy link
Contributor

eparis commented Jun 8, 2016

looks like a dupe of #25866 which should we take? Do we need for 1.3?

@jimmidyson
Copy link
Member Author

Sorry didn't see the other PR. They're both just bumps of json-patch, this one latest version which includes a fix for rfc 6901 compliant encoded property paths, fixing #26890. I'd take this one.

@jimmidyson
Copy link
Member Author

And yes I would say this is a good candidate for 1.3 as it's a bug that prevents rfc compliant json patch requests from being handled correctly.

@jimmidyson
Copy link
Member Author

Sorry this needs another bump after evanphx/json-patch#28 is merged - missed another possible path encoding.

@evanphx
Copy link

evanphx commented Jun 8, 2016

@jimmidyson json-patch has been updated

@jimmidyson jimmidyson force-pushed the json-patch-lib-upgrade branch from 56af7cf to fcb54cc Compare June 8, 2016 21:24
@jimmidyson
Copy link
Member Author

@evanphx Thanks!

@deads2k This is ready for review now.

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 9, 2016
@jimmidyson jimmidyson force-pushed the json-patch-lib-upgrade branch from fcb54cc to 0aec53a Compare June 9, 2016 07:15
@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 9, 2016
@eparis eparis added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Jun 9, 2016
@eparis eparis added this to the v1.3 milestone Jun 9, 2016
@eparis eparis added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 9, 2016
@eparis
Copy link
Contributor

eparis commented Jun 9, 2016

@k8s-bot node test this issue #IGNORE

it looks like it passed, but maybe didn't report results?

@jimmidyson
Copy link
Member Author

Hmm again tests seemed to pass but no feedback into Github PR status - any ideas @eparis?

@eparis
Copy link
Contributor

eparis commented Jun 10, 2016

@ixdy can you help figure out what's up with Node e2e or tell us who could?

@eparis
Copy link
Contributor

eparis commented Jun 10, 2016

@spxtr maybe you know how to help or what up with the node e2e

@ixdy
Copy link
Member

ixdy commented Jun 10, 2016

cc @fejta

@jimmidyson
Copy link
Member Author

Any ideas on why this isn't reporting back?

@fejta
Copy link
Contributor

fejta commented Jun 12, 2016

Yes, it didn't run because the trigger phrase is: (?is).*@k8s-bot\s+node\se2e\s+test\s+this.*|(?is).*@k8s-bot test node e2e experimental

@fejta
Copy link
Contributor

fejta commented Jun 12, 2016

@k8s-bot node e2e test this issue #IGNORE

@eparis
Copy link
Contributor

eparis commented Jun 12, 2016

Doesn't explain what happened the first time, but thanks.

@k8s-bot
Copy link

k8s-bot commented Jun 12, 2016

GCE e2e build/test passed for commit 0aec53a.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 59f918c into kubernetes:master Jun 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants