Allow conformance tests to run on non-GCE providers #26932
Conversation
|
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. Otherwise, if this message is too spammy, please complain to ixdy. |
2 similar comments
|
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. Otherwise, if this message is too spammy, please complain to ixdy. |
|
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. Otherwise, if this message is too spammy, please complain to ixdy. |
k8s-github-robot
added
size/L
| # prefix gets appended to itslef, with some extra information | ||
| # need tot keep it short | ||
| export KUBE_GCE_INSTANCE_PREFIX="${USER}-${zone}" | ||
| export KUBE_GCE_ZONE="$zone" |
There was a problem hiding this comment.
these lines should be indented from the if statement
There was a problem hiding this comment.
These are just converting from a mix of space/tab to tab only. So:
function set-federated-zone-vars {
\tif [[ "$KUBERNETES_PROVIDER" == "gce" ]];then
\t\texport KUBE_GCE_ZONE="$zone"
Did you want something else? Also, I'm fine with dropping the whitespace changes from this PR (unrelated). I was just already in the file and the space/tab mixed block rendered weird for me.
|
In the interest of not having this block on whitespace, I've dropped the space->tab changes. |
roberthbailey
added
lgtm
aaronlevy
force-pushed
the
conformance-fix
branch
from
294af9c to
e8d1dae
Compare
|
Just squashed changes. Probably going to drop the lgtm label.... |
k8s-github-robot
removed
the
lgtm
|
@roberthbailey I believe the test failure is unrelated to this change. Possible to get a re-test? |
|
@yifan-gu |
|
@pwittrock the node e2e test failed. can you investigate / kick it? |
|
@k8s-bot node e2e test this issue: #IGNORE |
dchen1107
added
the
lgtm
|
LGTM |
|
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. Otherwise, if this message is too spammy, please complain to ixdy. |
1 similar comment
|
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. Otherwise, if this message is too spammy, please complain to ixdy. |
|
ok to test |
|
Any thoughts on marking this as a p1 to try and get it into the 1.3 release. Kind of a bummer if non-GCE installations can't easily run conformance tests... |
|
It's marked for the release, but the node e2e test needs to pass before the submit queue will look at it. @pwittrock can you take a quick look at the node e2e failure? |
|
@dchen1107 @pwittrock who can take a look at these e2e node failures? |
|
@k8s-bot e2e test this issue: #IGNORE |
|
git checkout failed, didn't test anything @k8s-bot e2e test this issue: #IGNORE |
1 similar comment
|
git checkout failed, didn't test anything @k8s-bot e2e test this issue: #IGNORE |
|
@aaronlevy we'll need this test investigated and in the queue soon (today-ish) if this is still needed for the v1.3 release. Please take a look. |
|
@goltermann I might be missing something in the logs, but not sure if I can triage this error externally:
|
|
Thanks for looking, that's not exactly debuggable, I agree. @k8s-bot e2e test this issue: #IGNORE |
|
GCE e2e build/test passed for commit e8d1dae. |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test passed for commit e8d1dae. |
|
Automatic merge from submit-queue |
|
GCE e2e build/test passed for commit e8d1dae. |
Automatic merge from submit-queue Allow conformance tests to run on non-GCE providers fixes kubernetes#26869 Creates a skeleton provider which has all the required function stubs -- but will allow a previously set "skeleton" KUBERNETES_PROVIDER to not be overriden with "gce".
fixes #26869
Creates a skeleton provider which has all the required function stubs -- but will allow a previously set "skeleton" KUBERNETES_PROVIDER to not be overriden with "gce".