Updating federation up script to create secrets with federation-apiserver and k8s apiservers kubeconfigs #26914
Conversation
|
Am still testing it out |
k8s-github-robot
added
size/S
ghost
self-assigned this
|
@nikhiljindal Let me know as soon as it's ready for review. |
ghost
added
priority/important-soon
| @@ -146,6 +147,21 @@ function create-federated-api-objects { | |||
| sleep 4 | |||
| done | |||
|
|
|||
| # Create a kubeconfig with credentails for federation-apiserver and create a | |||
| # secret for it. | |||
There was a problem hiding this comment.
nit: This comment does not seem to apply to the next line of code?
|
Minor nit, otherwise LGTM. |
ghost
added
the
lgtm
|
Sorry I havent been able to get this to work yet. |
nikhiljindal
removed
the
lgtm
|
Here is the problem I am having: |
nikhiljindal
force-pushed
the
FedAPIServerSecret
branch
2 times, most recently
from
0adc75c to
d2d3697
Compare
k8s-github-robot
added
size/M
|
Updated the code. I am still having trouble with pushing my images, so federation-apiserver and federation-controller-manager are not coming up for me. @quinton-hoole PTAL. Should be ready to be merged |
| function clear-kubeconfig() { | ||
| export KUBECONFIG=${KUBECONFIG:-$DEFAULT_KUBECONFIG} | ||
| OVERRIDE_CONTEXT=${OVERRIDE_CONTEXT:-} |
There was a problem hiding this comment.
This is an independent change. Without this change, running hack/e2e.go --up followed by hack/e2e.go --down would leave contexts in kubeconfig that can affect later runs. This change ensures that kubeconfig is cleared correctly.
|
cc @colhom |
|
Same errors happening again. Unrelated to this PR |
nikhiljindal
force-pushed
the
FedAPIServerSecret
branch
from
d2d3697 to
b4da469
Compare
|
LGTM! |
ghost
added
the
lgtm
|
Added another commit to create secrets for the kubernetes apiservers as well. @quinton-hoole PTAL. |
nikhiljindal
changed the title
|
Note that I am creating secrets for k8s clusters only on GCE for now. In GKE script, we directly call gcloud create cluster to create the cluster: https://github.com/kubernetes/kubernetes/blob/master/cluster/gke/util.sh#L183. I guess that updates the kubeconfig as well. |
|
This PR with GCE only secrets should atleast unblock @madhusudancs for his service controller tests. |
k8s-github-robot
removed
the
lgtm
|
Awesome. LGTM. |
ghost
added
the
lgtm
|
@k8s-oncall @yujuhong could we merge this manually please? It's passed all checks, but the http://submit-queue.k8s.io/#/queue is currently stalled for unrelated reasons. This PR is blocking further e2e testing of cluster federation, which is in turn blocking the v1.3 launch. Thanks! |
|
@nikhiljindal Thank you very much! |
|
GCE e2e build/test passed for commit 9443bf0. |
|
Manually merging. See note above for rationale, |
ghost
merged commit Automatic merge from submit-queue federation: Creating kubeconfig files to be used for creating secrets for clusters on aws and gke Extension of #26914 which created the kubeconfig files for gce clusters. This PR extends it to AWS, vagrant and GKE. The change for AWS and vagrant is exactly same as GCE. For GKE, since `gcloud create clusters` creates kubeconfig, we are just copying the generated kubeconfig to the desired location cc @kubernetes/sig-cluster-federation @colhom @roberthbailey for GKE
Automatic merge from submit-queue federation: Creating kubeconfig files to be used for creating secrets for clusters on aws and gke Extension of kubernetes/kubernetes#26914 which created the kubeconfig files for gce clusters. This PR extends it to AWS, vagrant and GKE. The change for AWS and vagrant is exactly same as GCE. For GKE, since `gcloud create clusters` creates kubeconfig, we are just copying the generated kubeconfig to the desired location cc @kubernetes/sig-cluster-federation @colhom @roberthbailey for GKE
Follow up to #26819
cc @kubernetes/sig-cluster-federation