Generic atomic update code #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if err != nil { | ||
| // Don't strand stuff. | ||
| registry.etcdClient.Delete(podKey, false) |
There was a problem hiding this comment.
At least check and log the error here.
There was a problem hiding this comment.
Also, you dropped the return err from here.
There was a problem hiding this comment.
check & log err: good idea.
But I'm not dropping the original error. Moved the return to make it more clear.
|
Looks like an unstable map ordering issue from #254 caused this flake-- I'll fix. |
|
Added TODO about racy set. Should be good to go now. |
brendandburns
added a commit
that referenced
this pull request
Jun 27, 2014
Generic atomic update code
vishh
pushed a commit
to vishh/kubernetes
that referenced
this pull request
Apr 6, 2016
Adding --log_cadvisor_usage flag to log the resource usage of cAdvisor.
keontang
pushed a commit
to keontang/kubernetes
that referenced
this pull request
May 14, 2016
Sync image to index.caicloud.io and caicloudgcr
keontang
pushed a commit
to keontang/kubernetes
that referenced
this pull request
Jul 1, 2016
Sync image to index.caicloud.io and caicloudgcr
harryge00
pushed a commit
to harryge00/kubernetes
that referenced
this pull request
Aug 11, 2016
Sync image to index.caicloud.io and caicloudgcr
mqliang
pushed a commit
to mqliang/kubernetes
that referenced
this pull request
Dec 8, 2016
Sync image to index.caicloud.io and caicloudgcr
mqliang
pushed a commit
to mqliang/kubernetes
that referenced
this pull request
Mar 3, 2017
Sync image to index.caicloud.io and caicloudgcr
b3atlesfan
pushed a commit
to b3atlesfan/kubernetes
that referenced
this pull request
Feb 5, 2021
Actually process -m flag in mk-docker-opts.sh
avalluri
added a commit
to avalluri/kubernetes
that referenced
this pull request
May 2, 2021
This is a first step towards removing the mock CSI driver completely from e2e testing in favor of hostpath plugin. With the recent hostpath plugin changes(PR kubernetes#260, kubernetes#269), it supports all the features supported by the mock csi driver. Using hostpath-plugin for testing also covers CSI persistent feature usecases.
pohly
pushed a commit
to pohly/kubernetes
that referenced
this pull request
Dec 2, 2021
This is a first step towards removing the mock CSI driver completely from e2e testing in favor of hostpath plugin. With the recent hostpath plugin changes(PR kubernetes#260, kubernetes#269), it supports all the features supported by the mock csi driver. Using hostpath-plugin for testing also covers CSI persistent feature usecases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couldn't resist doing a little cleanup before writing a test.