Kubelet Volume Attach/Detach/Mount/Unmount Redesign #26801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saad-ali
added
priority/backlog
k8s-github-robot
added
kind/api-change
saad-ali
force-pushed
the
mountUnmountRedesign
branch
from
493760a to
b6baed7
Compare
pmorie
added
sig/storage
k8s-github-robot
added
the
needs-rebase
saad-ali
force-pushed
the
mountUnmountRedesign
branch
from
b6baed7 to
840f0be
Compare
k8s-github-robot
removed
the
needs-rebase
saad-ali
force-pushed
the
mountUnmountRedesign
branch
from
840f0be to
11f1393
Compare
k8s-github-robot
added
the
needs-rebase
saad-ali
force-pushed
the
mountUnmountRedesign
branch
from
98c504a to
6cdeb6d
Compare
k8s-github-robot
added
needs-rebase
saad-ali
force-pushed
the
mountUnmountRedesign
branch
from
6cdeb6d to
557556e
Compare
k8s-github-robot
removed
the
needs-rebase
saad-ali
force-pushed
the
mountUnmountRedesign
branch
from
557556e to
6b92518
Compare
| @@ -2386,11 +2386,11 @@ type NodeStatus struct { | |||
| NodeInfo NodeSystemInfo `json:"nodeInfo,omitempty" protobuf:"bytes,7,opt,name=nodeInfo"` | |||
| // List of container images on this node | |||
| Images []ContainerImage `json:"images,omitempty" protobuf:"bytes,8,rep,name=images"` | |||
| // List of volumes in use (mounted) by the node. | |||
| VolumesInUse []UniqueDeviceName `json:"volumesInUse,omitempty" protobuf:"bytes,9,rep,name=volumesInUse"` | |||
| // List of attachable volume devices in use (mounted) by the node. | |||
There was a problem hiding this comment.
Doesn't match the internal API description.
pmorie
added
the
lgtm
saad-ali
added
priority/important-soon
k8s-github-robot
added
the
needs-rebase
saad-ali
force-pushed
the
mountUnmountRedesign
branch
from
b2031c3 to
3c09a88
Compare
k8s-github-robot
removed
lgtm
saad-ali
added
the
lgtm
saad-ali
force-pushed
the
mountUnmountRedesign
branch
from
3c09a88 to
2f97e51
Compare
k8s-github-robot
added
needs-rebase
Rename UniqueDeviceName to UniqueVolumeName and move helper functions from attacherdetacher to volumehelper package. Introduce UniquePodName alias
This commit adds a new volume manager in kubelet that synchronizes volume mount/unmount (and attach/detach, if attach/detach controller is not enabled). This eliminates the race conditions between the pod creation loop and the orphaned volumes loops. It also removes the unmount/detach from the `syncPod()` path so volume clean up never blocks the `syncPod` loop.
saad-ali
force-pushed
the
mountUnmountRedesign
branch
from
2f97e51 to
cfab536
Compare
saad-ali
added
the
lgtm
k8s-github-robot
removed
the
needs-rebase
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test passed for commit cfab536. |
|
Automatic merge from submit-queue |
This was referenced Jun 19, 2016
dims
pushed a commit
to dims/kubernetes
that referenced
this pull request
Feb 8, 2018
Automatic merge from submit-queue Kubelet Volume Attach/Detach/Mount/Unmount Redesign This PR redesigns the Volume Attach/Detach/Mount/Unmount in Kubelet as proposed in kubernetes#21931 ```release-note A new volume manager was introduced in kubelet that synchronizes volume mount/unmount (and attach/detach, if attach/detach controller is not enabled). This eliminates the race conditions between the pod creation loop and the orphaned volumes loops. It also removes the unmount/detach from the `syncPod()` path so volume clean up never blocks the `syncPod` loop. ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR redesigns the Volume Attach/Detach/Mount/Unmount in Kubelet as proposed in #21931