Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always skew the client when running version-skew tests #26789

Merged
merged 1 commit into from
Jun 7, 2016
Merged

Always skew the client when running version-skew tests #26789

merged 1 commit into from
Jun 7, 2016

Conversation

ikehz
Copy link
Contributor

@ikehz ikehz commented Jun 3, 2016

As mentioned in the comments:

  • for upgrade jobs, we want kubectl to be at the same version as master.
  • for client skew tests, we want to use the skewed kubectl (that's what we're testing).

So, remove gate on JENKINS_USE_SKEW_KUBECTL, and always use the skewed kubectl.

This should go in before kubernetes/test-infra#109.

@ikehz ikehz mentioned this pull request Jun 3, 2016
Merged
@ikehz ikehz added the release-note-none Denotes a PR that doesn't merit a release note. label Jun 3, 2016
@ikehz
Copy link
Contributor Author

ikehz commented Jun 3, 2016

Fixes #26657.

@k8s-github-robot k8s-github-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 3, 2016
@ikehz
Copy link
Contributor Author

ikehz commented Jun 3, 2016

cc @maisem

@spxtr spxtr added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 6, 2016
@ikehz ikehz added this to the v1.3 milestone Jun 6, 2016
@ikehz
Copy link
Contributor Author

ikehz commented Jun 6, 2016

@k8s-oncall I'd like to merge this manually asap.

@k8s-bot
Copy link

k8s-bot commented Jun 6, 2016

GCE e2e build/test passed for commit 28738ff.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 72b1be9 into kubernetes:master Jun 7, 2016
This was referenced Jun 9, 2016
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@spxtr spxtr

Labels
area/test area/test-infra area/upgrade lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.
5 participants
@ikehz @k8s-bot @k8s-github-robot @googlebot @spxtr