Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make discovery summarizer call servers in parallel #26705

Merged
merged 1 commit into from
Jul 18, 2016
Merged

Make discovery summarizer call servers in parallel #26705

merged 1 commit into from
Jul 18, 2016

Conversation

nebril
Copy link
Contributor

@nebril nebril commented Jun 2, 2016

fixes #26704

@k8s-bot
Copy link

k8s-bot commented Jun 2, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

2 similar comments
@k8s-bot
Copy link

k8s-bot commented Jun 2, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

@k8s-bot
Copy link

k8s-bot commented Jun 2, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-label-needed labels Jun 2, 2016
@nikhiljindal
Copy link
Contributor

ok to test

@mikedanese mikedanese assigned nikhiljindal and unassigned mikedanese Jun 6, 2016
@k8s-bot
Copy link

k8s-bot commented Jun 14, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

1 similar comment
@k8s-bot
Copy link

k8s-bot commented Jun 15, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

@nikhiljindal
Copy link
Contributor

ok to test

@nikhiljindal
Copy link
Contributor

LGTM, thanks!

@nikhiljindal nikhiljindal added release-note Denotes a PR that will be considered when it comes time to generate release notes. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed release-note-label-needed labels Jun 21, 2016
@k8s-bot
Copy link

k8s-bot commented Jun 23, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

@nikhiljindal
Copy link
Contributor

Unit tests failed on Jenkins with the following log:

Verifying ./hack/../hack/verify-gofmt.sh
!!! 'gofmt -s -w' needs to be run on the following files: 
./cmd/kubernetes-discovery/discoverysummarizer/discoverysummarizer.go
FAILED   ./hack/../hack/verify-gofmt.sh 9s
Verifying ./hack/../hack/verify-govet.sh
cmd/kubernetes-discovery/discoverysummarizer/discoverysummarizer.go:110: range variable serverAddress captured by func literal
exit status 1
!!! Error in ./hack/../hack/verify-govet.sh:49
  'go vet "${goflags[@]:+${goflags[@]}}" ${targets[@]}' exited with status 1
Call stack:
  1: ./hack/../hack/verify-govet.sh:49 main(...)
Exiting with status 1
FAILED   ./hack/../hack/verify-govet.sh 260s

@nebril Can you please fix?

@nebril
Copy link
Contributor Author

nebril commented Jun 27, 2016

Sure, will fix. Thanks for the help!

@wojtek-t
Copy link
Member

wojtek-t commented Jul 6, 2016

@nebril - friendly ping; can you please fix it?

@nebril
Copy link
Contributor Author

nebril commented Jul 6, 2016

@wojtek-t yeah, it got stuck in my backlog. Will try to fix tests tomorrow, thanks for the ping!

@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 7, 2016
@nebril
Copy link
Contributor Author

nebril commented Jul 8, 2016

@nikhiljindal fixed!

@nebril
Copy link
Contributor Author

nebril commented Jul 13, 2016

@nikhiljindal can I bother you for lgtm on this before I need to rebase it? :)

@nikhiljindal
Copy link
Contributor

LGTM, thanks!

@nikhiljindal nikhiljindal added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 18, 2016
@k8s-bot
Copy link

k8s-bot commented Jul 18, 2016

GCE e2e build/test passed for commit ee6f50e.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Jul 18, 2016

GCE e2e build/test passed for commit ee6f50e.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 9b5696b into kubernetes:master Jul 18, 2016
@nebril nebril deleted the issue-26704 branch July 18, 2016 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nikhiljindal nikhiljindal

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parallelize API calls in discovery summarizer
7 participants
@nebril @k8s-bot @nikhiljindal @wojtek-t @k8s-github-robot @mikedanese @googlebot