-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken warning image link in docs #26702
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. Otherwise, if this message is too spammy, please complain to ixdy. |
2 similar comments
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. Otherwise, if this message is too spammy, please complain to ixdy. |
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. Otherwise, if this message is too spammy, please complain to ixdy. |
Adding label:do-not-merge because PR changes docs prohibited to auto merge |
CLAs look good, thanks! |
@johndmulhausen This touches "old docs" in the main repo. As long as those docs exist, we will have this conflict. Should we leave the old docs broken? Or should we fix them this one time and override the do-not-merge? Or should we remove the old docs from the main repo? |
c441a96
to
19888d9
Compare
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. Otherwise, if this message is too spammy, please complain to ixdy. |
1 similar comment
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. Otherwise, if this message is too spammy, please complain to ixdy. |
19888d9
to
ae67551
Compare
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. Otherwise, if this message is too spammy, please complain to ixdy. |
ae67551
to
2762172
Compare
2762172
to
0dca3d8
Compare
0dca3d8
to
88b6d4a
Compare
GCE e2e build/test passed for commit 88b6d4a. |
This PR hasn't been active in 42 days. Will be closed in 47 days. You can add 'keep-open' label to prevent this from happening. |
@thockin / @johndmulhausen - Can this be merged? |
ok to test pr builder appears to be missing, activating due to 'lgtm' label. |
I'm going to manually merge this to bypass the old docs rule. |
GCE e2e build/test failed for commit 88b6d4a. Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake. |
heh, this likely broke verification. |
There were a couple of other docs files added (with the existing header) before this got merged. |
Fix broken warning image link in docs
Fix broken warning image link in docs
Fix broken warning image link in docs
Fix broken warning image link in docs
fixes #26357