--no-header available now for custom-column #26696

sylwekb · 2016-06-02T10:22:24Z

Change CustomColumnsPrinter to have noHeader boolean, also changed GetPrinter to receive this bool and pass it through.
One test TestNewColumnPrinterFromSpecWithNoHeaders added for checking if there is no headers in output for sure

fixes #24133

k8s-bot · 2016-06-02T10:23:12Z

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

k8s-bot · 2016-06-02T10:24:16Z

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

k8s-bot · 2016-06-02T10:24:34Z

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

janetkuo · 2016-06-03T01:26:54Z

ok to test

janetkuo · 2016-06-08T17:50:28Z

@Gitfred thanks for submitting the fix, although this needs to wait until after the 1.3 code freeze ends.

k8s-bot · 2016-06-14T23:04:45Z

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

k8s-bot · 2016-06-15T00:33:06Z

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

k8s-bot · 2016-06-23T22:07:01Z

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

janetkuo · 2016-06-24T23:17:16Z

pkg/kubectl/cmd/util/printing.go

@@ -32,7 +32,7 @@ import (
 func AddPrinterFlags(cmd *cobra.Command) {
 	cmd.Flags().StringP("output", "o", "", "Output format. One of: json|yaml|wide|name|go-template=...|go-template-file=...|jsonpath=...|jsonpath-file=... See golang template [http://golang.org/pkg/text/template/#pkg-overview] and jsonpath template [http://releases.k8s.io/HEAD/docs/user-guide/jsonpath.md].")
 	cmd.Flags().String("output-version", "", "Output the formatted object with the given group version (for ex: 'extensions/v1beta1').")
-	cmd.Flags().Bool("no-headers", false, "When using the default output, don't print headers.")
+	cmd.Flags().Bool("no-headers", false, "When using the default output (except for custom-column), don't print headers.")


Why except for custom-column? Isn't it supported in this PR?

the sentence says "no-header works only for default output". Custom-column is not default so I put "except for custom-column" there :) I see it is not so readable as I thought. Any ideas how to improve it?

k8s-bot · 2016-06-25T01:00:02Z

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

sylwekb · 2016-06-27T13:18:51Z

@janetkuo updated.

janetkuo · 2016-07-07T01:03:13Z

pkg/kubectl/cmd/util/printing.go

@@ -52,7 +52,7 @@ func AddOutputFlags(cmd *cobra.Command) {

 // AddNoHeadersFlags adds no-headers flags to a command.
 func AddNoHeadersFlags(cmd *cobra.Command) {
-	cmd.Flags().Bool("no-headers", false, "When using the default output, don't print headers.")
+	cmd.Flags().Bool("no-headers", false, "When using the default output, don't print headers (except for not default custom-column, it also works then).")


How about When using the default or custom-column output format, don't print headers.

janetkuo · 2016-07-07T01:12:56Z

I made a few more comments.

janetkuo · 2016-07-07T21:25:20Z

LGTM now. Thanks much @Gitfred!

janetkuo · 2016-07-07T22:40:16Z

@k8s-bot e2e test this issue: #26760

wojtek-t · 2016-07-08T11:56:41Z

@k8s-bot e2e test this please, issue: #27462

dims · 2016-07-08T17:55:46Z

looks good to me 👍

janetkuo · 2016-07-11T20:35:35Z

@k8s-bot node e2e test this issue: #28683

k8s-bot · 2016-07-11T21:13:10Z

GCE e2e build/test passed for commit 19434e1.

k8s-github-robot · 2016-07-11T22:39:11Z

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

k8s-bot · 2016-07-11T23:10:55Z

GCE e2e build/test passed for commit 19434e1.

k8s-github-robot · 2016-07-11T23:11:22Z

Automatic merge from submit-queue

googlebot added the cla: yes label Jun 2, 2016

k8s-github-robot assigned thockin Jun 2, 2016

k8s-github-robot added kind/old-docs size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 2, 2016

thockin assigned janetkuo and unassigned thockin Jun 2, 2016

sylwekb force-pushed the no-header-custom-column branch from 90ba785 to aa81489 Compare June 3, 2016 08:59

k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 10, 2016

sylwekb force-pushed the no-header-custom-column branch from aa81489 to 0810b94 Compare June 10, 2016 07:49

k8s-github-robot removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. kind/old-docs labels Jun 10, 2016

janetkuo reviewed Jun 24, 2016
View reviewed changes

sylwekb force-pushed the no-header-custom-column branch from 0810b94 to 54facd2 Compare June 27, 2016 13:18

k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 5, 2016

sylwekb force-pushed the no-header-custom-column branch from 54facd2 to 044fe6d Compare July 6, 2016 06:54

k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 6, 2016

janetkuo reviewed Jul 7, 2016
View reviewed changes

janetkuo added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-label-needed labels Jul 7, 2016

24133 fix: --no-headers works with custom columns now

19434e1

sylwekb force-pushed the no-header-custom-column branch from 044fe6d to 19434e1 Compare July 7, 2016 08:04

janetkuo added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 7, 2016

k8s-github-robot merged commit 30c43e6 into kubernetes:master Jul 11, 2016

vtereso mentioned this pull request May 15, 2019

Update installation-functions.sh openshift-cloud-functions/knative-operators#38

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

--no-header available now for custom-column #26696

--no-header available now for custom-column #26696

sylwekb commented Jun 2, 2016

k8s-bot commented Jun 2, 2016

k8s-bot commented Jun 2, 2016

k8s-bot commented Jun 2, 2016

janetkuo commented Jun 3, 2016

janetkuo commented Jun 8, 2016

k8s-bot commented Jun 14, 2016

k8s-bot commented Jun 15, 2016

k8s-bot commented Jun 23, 2016

janetkuo Jun 24, 2016

sylwekb Jun 27, 2016 •

edited

Loading

k8s-bot commented Jun 25, 2016

sylwekb commented Jun 27, 2016

janetkuo Jul 7, 2016

janetkuo commented Jul 7, 2016

janetkuo commented Jul 7, 2016

janetkuo commented Jul 7, 2016

wojtek-t commented Jul 8, 2016

dims commented Jul 8, 2016

janetkuo commented Jul 11, 2016 •

edited

Loading

k8s-bot commented Jul 11, 2016

k8s-github-robot commented Jul 11, 2016

k8s-bot commented Jul 11, 2016

k8s-github-robot commented Jul 11, 2016

--no-header available now for custom-column #26696

--no-header available now for custom-column #26696

Conversation

sylwekb commented Jun 2, 2016

k8s-bot commented Jun 2, 2016

k8s-bot commented Jun 2, 2016

k8s-bot commented Jun 2, 2016

janetkuo commented Jun 3, 2016

janetkuo commented Jun 8, 2016

k8s-bot commented Jun 14, 2016

k8s-bot commented Jun 15, 2016

k8s-bot commented Jun 23, 2016

janetkuo Jun 24, 2016

Choose a reason for hiding this comment

sylwekb Jun 27, 2016 • edited Loading

Choose a reason for hiding this comment

k8s-bot commented Jun 25, 2016

sylwekb commented Jun 27, 2016

janetkuo Jul 7, 2016

Choose a reason for hiding this comment

janetkuo commented Jul 7, 2016

janetkuo commented Jul 7, 2016

janetkuo commented Jul 7, 2016

wojtek-t commented Jul 8, 2016

dims commented Jul 8, 2016

janetkuo commented Jul 11, 2016 • edited Loading

k8s-bot commented Jul 11, 2016

k8s-github-robot commented Jul 11, 2016

k8s-bot commented Jul 11, 2016

k8s-github-robot commented Jul 11, 2016

sylwekb Jun 27, 2016 •

edited

Loading

janetkuo commented Jul 11, 2016 •

edited

Loading