Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update strategic patch test for merge list of maps #26510

Merged
merged 1 commit into from
Aug 16, 2016
Merged

update strategic patch test for merge list of maps #26510

merged 1 commit into from
Aug 16, 2016
+8 −0

Conversation

adohe-zz
Copy link

@adohe-zz adohe-zz commented May 30, 2016 •
edited by k8s-oncall
Loading

Refer #26418 for more details. @janetkuo the test case is added, ptal.

This change is Reviewable

@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels May 30, 2016
@adohe-zz
Copy link
Author

adohe-zz commented Jun 8, 2016

@janetkuo kindly ping.

@adohe-zz
Copy link
Author

@janetkuo kindly ping, ptal.

@adohe-zz
Copy link
Author

@janetkuo kindly ping. Is this test still necessary or I will close this pr?

@k8s-github-robot k8s-github-robot added do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. retest-not-required-docs-only and removed retest-not-required-docs-only labels Jul 28, 2016
@apelisse apelisse removed the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Aug 11, 2016
@adohe-zz
Copy link
Author

@pwittrock would you please help with this one? Seem @janetkuo is quite busy.

@pwittrock pwittrock assigned pwittrock and unassigned dchen1107 Aug 15, 2016
@pwittrock pwittrock added lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Aug 15, 2016
@pwittrock
Copy link
Member

@adohe Yes. Sorry you were blocked for so long.

@pwittrock
Copy link
Member

@k8s-bot e2e test this issue: #IGNORE Hung tests

@pwittrock
Copy link
Member

@k8s-bot test this issue: #IGNORE Hung tests

@k8s-bot
Copy link

k8s-bot commented Aug 15, 2016

GCE e2e build/test passed for commit d06a770.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot k8s-github-robot mentioned this pull request Aug 16, 2016
Closed
@k8s-bot
Copy link

k8s-bot commented Aug 16, 2016

GCE e2e build/test passed for commit d06a770.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 096dd4d into kubernetes:master Aug 16, 2016
@adohe-zz adohe-zz deleted the patch_test branch August 16, 2016 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pwittrock pwittrock

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@adohe-zz @pwittrock @k8s-bot @k8s-github-robot @apelisse @googlebot @dchen1107 @adohe