[GarbageCollector] Add garbage collector into kube-controller-manager #26341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caesarxuchao
added
sig/api-machinery
|
I think we need this piece for 1.3. @lavalamp |
k8s-github-robot
added
kind/api-change
| @@ -153,5 +154,6 @@ func (s *CMServer) AddFlags(fs *pflag.FlagSet) { | |||
| fs.Float32Var(&s.KubeAPIQPS, "kube-api-qps", s.KubeAPIQPS, "QPS to use while talking with kubernetes apiserver") | |||
| fs.Int32Var(&s.KubeAPIBurst, "kube-api-burst", s.KubeAPIBurst, "Burst to use while talking with kubernetes apiserver") | |||
| fs.DurationVar(&s.ControllerStartInterval.Duration, "controller-start-interval", s.ControllerStartInterval.Duration, "Interval between starting controller managers.") | |||
| fs.BoolVar(&s.EnableGarbageCollector, "enable-garbage-collector", s.EnableGarbageCollector, "enables the generic garbage collector. MUST be synced with the corresponding flag of the kube-apiserver. WARNING: the generic garbage collector is an alpha feature") | |||
There was a problem hiding this comment.
s/enables/Enables/
end with a period.
|
LGTM one nit. |
caesarxuchao
force-pushed
the
gc-controller-manager
branch
from
292977b to
b74bd2f
Compare
|
Address the nit. Applying the lgtm per comment. |
caesarxuchao
added
the
lgtm
k8s-github-robot
added
the
needs-rebase
caesarxuchao
force-pushed
the
gc-controller-manager
branch
from
b74bd2f to
b3df629
Compare
caesarxuchao
added
lgtm
|
Added back the lgtm after trivial rebase. |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test passed for commit b3df629. |
|
Automatic merge from submit-queue |
erictune
removed
the
release-note-action-required
caesarxuchao
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's disabled by default.
Design doc is at https://github.com/kubernetes/kubernetes/blob/master/docs/proposals/garbage-collection.md
This change is