Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated generated typed clients #26336

Conversation

caesarxuchao
Copy link
Member

@caesarxuchao caesarxuchao commented May 26, 2016

The typed clients had been moved to _pkg/client/clientset_generated/xxx/typed_.

@kubernetes/sig-api-machinery @lavalamp


This change is Reviewable

@caesarxuchao caesarxuchao added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label May 26, 2016
@k8s-github-robot k8s-github-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. release-note-label-needed labels May 26, 2016
@k8s-bot
Copy link

k8s-bot commented May 26, 2016

GCE e2e build/test passed for commit 06bac1f.

@lavalamp
Copy link
Member

If people were using these files they should switch to using what?

@caesarxuchao
Copy link
Member Author

They should switch to use pkg/client/clientset_generated/internalClientset/typed.

@lavalamp
Copy link
Member

LGTM

@lavalamp lavalamp added release-note Denotes a PR that will be considered when it comes time to generate release notes. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed release-note-label-needed labels May 26, 2016
@lavalamp lavalamp added this to the v1.3 milestone May 26, 2016
@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit b6929e1 into kubernetes:master May 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants