Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor util clock into it's own pkg #26332

Merged
merged 1 commit into from
Jul 28, 2016

Conversation

resouer
Copy link
Contributor

@resouer resouer commented May 26, 2016

Continue my work ref #15634

@k8s-github-robot k8s-github-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note-label-needed labels May 26, 2016
@yujuhong yujuhong added release-note-none Denotes a PR that doesn't merit a release note. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed release-note-label-needed labels May 26, 2016
@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 27, 2016
@k8s-github-robot k8s-github-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 28, 2016
@yujuhong yujuhong added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 31, 2016
@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 2, 2016
@k8s-github-robot k8s-github-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 6, 2016
@yujuhong yujuhong added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 6, 2016
@resouer
Copy link
Contributor Author

resouer commented Jun 17, 2016

@k8s-bot e2e test this issue: #27335

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 22, 2016
@k8s-github-robot k8s-github-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 22, 2016
@resouer
Copy link
Contributor Author

resouer commented Jun 22, 2016

Fixed rebase again > <

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 30, 2016
@yujuhong
Copy link
Contributor

@resouer too bad you'll need to rebase again :-(

Let's hope this is the last time since the queue is now open to all PRs.

@yujuhong
Copy link
Contributor

ping?

@resouer
Copy link
Contributor Author

resouer commented Jul 12, 2016

Ah, sorry for missing this notification, will update this soon

On Tue, Jul 12, 2016 at 12:32 AM, Yu-Ju Hong notifications@github.com
wrote:

ping?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#26332 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ABn3lpO-sZEnFQ5VUixfyql9BCTxwjapks5qUnAGgaJpZM4InKVd
.

@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 12, 2016
@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 20, 2016
@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 26, 2016
@yujuhong
Copy link
Contributor

Failed unit test ..

@yujuhong
Copy link
Contributor

@resouer

ok      k8s.io/kubernetes/pkg/kubectl/cmd/config    2.048s
ok      k8s.io/kubernetes/pkg/kubectl/cmd/util  2.667s
ok      k8s.io/kubernetes/pkg/kubectl/cmd/util/editor   1.024s
ok      k8s.io/kubernetes/pkg/kubectl/resource  1.391s
FAIL    k8s.io/kubernetes/pkg/kubelet [build failed]
ok      k8s.io/kubernetes/pkg/kubelet/client    1.173s
ok      k8s.io/kubernetes/pkg/kubelet/cm    2.021s
ok      k8s.io/kubernetes/pkg/kubelet/config    1.341s
ok      k8s.io/kubernetes/pkg/kubelet/container 1.123s

The change looks good to me. Once you fix the build failure, I'll apply the label. Thanks!

@resouer
Copy link
Contributor Author

resouer commented Jul 27, 2016

i can not re-produce this failure by doing make test in local. really don't know why ...

@yujuhong
Copy link
Contributor

It's an easy fix :-)
From the build.log:

# k8s.io/kubernetes/pkg/kubelet
pkg/kubelet/kubelet_test.go:64: imported and not used: "k8s.io/kubernetes/pkg/util"

@k8s-github-robot k8s-github-robot added do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. retest-not-required-docs-only and removed retest-not-required-docs-only labels Jul 28, 2016
@resouer
Copy link
Contributor Author

resouer commented Jul 28, 2016

Aha, pkg/util is used in my commit, that's what I am struggling, but actually it has been deleted in a latest commit, that's why CI will complain after it do rebase but I can not reproduce it locally ...

@k8s-bot
Copy link

k8s-bot commented Jul 28, 2016

GCE e2e build/test passed for commit cb14b35.

@yujuhong yujuhong added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Jul 28, 2016
@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Jul 28, 2016

GCE e2e build/test passed for commit cb14b35.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit eae90a3 into kubernetes:master Jul 28, 2016
@resouer resouer deleted the util-debt branch July 29, 2016 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants