-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support --all-namespaces in kubectl describe #26315
Conversation
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. Otherwise, if this message is too spammy, please complain to ixdy. |
2 similar comments
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. Otherwise, if this message is too spammy, please complain to ixdy. |
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. Otherwise, if this message is too spammy, please complain to ixdy. |
Are you sure that it works? I tried to use your code and it still has a problem with selecting the concrete service outside of the default namespace:
And the piece of code which shows this error seems to be untouched here. |
@nhlfr : my PR was for describe not get - "kubectl describe --all-namespaces services" (and not "kubectl get --all-namespaces services") |
Um, sorry. Then LGTM |
Hey Dims!. I think it should be 'kubectl describe services --all-namespaces' in your doc patch instead of 'kubectl get services --all-namespaces'. |
@rthallisey oops! thanks. fixed. |
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. Otherwise, if this message is too spammy, please complain to ixdy. |
1 similar comment
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. Otherwise, if this message is too spammy, please complain to ixdy. |
@k8s-bot ok to test |
Apologies, I missed this pr right when we went into code slush for 1.3. Looks good, will add tag when tests are green. |
GCE e2e build/test passed for commit 1c8b8cf21ea1793729860db1abf88c7fa9dd81b5. |
GCE e2e build/test passed for commit de7416d7e3442497144e07a66b5b6f13c865ab4c. |
cc @johndmulhausen do you know why mergebot is blocking on docs? |
@k8s-oncall Any tips on how i can unblock this PR? |
cc @david-mcmahon @lavalamp Will this have to be manually merged? |
Hopefully @johndmulhausen can clarify. AFAIK most docs are on the docs site, but I'm not sure why the bot still warns/blocks on some of the docs in the tree. |
@johndmulhausen @eparis : i've submitted another PR for the bot to whitelist the cheatsheet.md - kubernetes-retired/contrib#1332 |
I do not believe that |
GCE e2e build/test passed for commit c879e69. |
@k8s-bot please test this: #IGNORE |
@eparis I agree. Filed kubernetes/website#796 |
@k8s-bot test this please, issue: #IGNORE |
GCE e2e build/test passed for commit c879e69. |
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
GCE e2e build/test passed for commit c879e69. |
Automatic merge from submit-queue |
Work In Progress :)
Fixes #26303