Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support --all-namespaces in kubectl describe #26315

Merged
merged 1 commit into from
Jul 10, 2016

Conversation

dims
Copy link
Member

@dims dims commented May 25, 2016

Work In Progress :)

Fixes #26303

@k8s-bot
Copy link

k8s-bot commented May 25, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

2 similar comments
@k8s-bot
Copy link

k8s-bot commented May 25, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

@k8s-bot
Copy link

k8s-bot commented May 25, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels May 25, 2016
@dims dims force-pushed the fix-issue-26303 branch from dd4c867 to c8b97ca Compare May 26, 2016 01:10
@k8s-github-robot k8s-github-robot added kind/old-docs do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels May 26, 2016
@nhlfr
Copy link

nhlfr commented May 31, 2016

Are you sure that it works? I tried to use your code and it still has a problem with selecting the concrete service outside of the default namespace:

$ ./_output/local/bin/linux/amd64/kubectl create namespace kopytko                                                                                                                                       
namespace "kopytko" created
$ ./_output/local/bin/linux/amd64/kubectl --namespace=kopytko create -f ~/playground/k8s/downward-old.yaml                                                                                                 
pod "kubernetes-downwardapi-volume-example" created
$ ./_output/local/bin/linux/amd64/kubectl --namespace=kopytko create -f ~/playground/k8s/service.yaml 
service "my-service" created
$ ./_output/local/bin/linux/amd64/kubectl get --all-namespaces services                                                                                                                                  
NAMESPACE   NAME         CLUSTER-IP   EXTERNAL-IP   PORT(S)   AGE
default     kubernetes   10.0.0.1     <none>        443/TCP   48m
kopytko     my-service   10.0.0.68    <none>        80/TCP    4m
$ ./_output/local/bin/linux/amd64/kubectl get --all-namespaces services my-service
error: namespace may not be empty when retrieving a resource by name

And the piece of code which shows this error seems to be untouched here.

@dims
Copy link
Member Author

dims commented May 31, 2016

@nhlfr : my PR was for describe not get - "kubectl describe --all-namespaces services" (and not "kubectl get --all-namespaces services")

@nhlfr
Copy link

nhlfr commented May 31, 2016

Um, sorry. Then LGTM

@rthallisey
Copy link

Hey Dims!. I think it should be 'kubectl describe services --all-namespaces' in your doc patch instead of 'kubectl get services --all-namespaces'.

@dims dims force-pushed the fix-issue-26303 branch from c8b97ca to 154e8c0 Compare June 6, 2016 02:14
@dims
Copy link
Member Author

dims commented Jun 6, 2016

@rthallisey oops! thanks. fixed.

@dims dims force-pushed the fix-issue-26303 branch from 154e8c0 to ad0f5c3 Compare June 6, 2016 02:23
@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 10, 2016
@k8s-bot
Copy link

k8s-bot commented Jun 14, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

1 similar comment
@k8s-bot
Copy link

k8s-bot commented Jun 23, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

@dims dims force-pushed the fix-issue-26303 branch from ad0f5c3 to 1c8b8cf Compare June 24, 2016 20:03
@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 24, 2016
@j3ffml
Copy link
Contributor

j3ffml commented Jun 28, 2016

@k8s-bot ok to test

@j3ffml j3ffml added this to the next-candidate milestone Jun 28, 2016
@j3ffml j3ffml added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-label-needed labels Jun 28, 2016
@j3ffml
Copy link
Contributor

j3ffml commented Jun 28, 2016

Apologies, I missed this pr right when we went into code slush for 1.3. Looks good, will add tag when tests are green.

@k8s-bot
Copy link

k8s-bot commented Jun 28, 2016

GCE e2e build/test passed for commit 1c8b8cf21ea1793729860db1abf88c7fa9dd81b5.

@j3ffml j3ffml removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. kind/old-docs labels Jun 29, 2016
@k8s-bot
Copy link

k8s-bot commented Jul 5, 2016

GCE e2e build/test passed for commit de7416d7e3442497144e07a66b5b6f13c865ab4c.

@j3ffml j3ffml added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. kind/old-docs labels Jul 6, 2016
@k8s-github-robot k8s-github-robot added kind/old-docs do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Jul 6, 2016
@j3ffml
Copy link
Contributor

j3ffml commented Jul 6, 2016

cc @johndmulhausen do you know why mergebot is blocking on docs?

@dims
Copy link
Member Author

dims commented Jul 7, 2016

@k8s-oncall Any tips on how i can unblock this PR?

@krousey
Copy link
Contributor

krousey commented Jul 7, 2016

cc @david-mcmahon @lavalamp Will this have to be manually merged?

@david-mcmahon
Copy link
Contributor

Hopefully @johndmulhausen can clarify. AFAIK most docs are on the docs site, but I'm not sure why the bot still warns/blocks on some of the docs in the tree.

@dims
Copy link
Member Author

dims commented Jul 8, 2016

@johndmulhausen @eparis : i've submitted another PR for the bot to whitelist the cheatsheet.md - kubernetes-retired/contrib#1332

@eparis
Copy link
Contributor

eparis commented Jul 8, 2016

I do not believe that kubectl-cheatsheet.md belongs in the repo at all. This is not auto-generated and thus is an actual user doc which belongs in kubernetes.github.io. @erictune

@dims dims force-pushed the fix-issue-26303 branch from de7416d to c879e69 Compare July 8, 2016 15:45
@k8s-github-robot k8s-github-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. kind/old-docs labels Jul 8, 2016
@eparis eparis added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Jul 8, 2016
@k8s-bot
Copy link

k8s-bot commented Jul 8, 2016

GCE e2e build/test passed for commit c879e69.

@dims
Copy link
Member Author

dims commented Jul 8, 2016

@k8s-bot please test this: #IGNORE

@erictune
Copy link
Member

erictune commented Jul 8, 2016

@eparis I agree. Filed kubernetes/website#796

@dims
Copy link
Member Author

dims commented Jul 8, 2016

@erictune @eparis thanks!

@dims
Copy link
Member Author

dims commented Jul 10, 2016

@k8s-bot test this please, issue: #IGNORE

@k8s-bot
Copy link

k8s-bot commented Jul 10, 2016

GCE e2e build/test passed for commit c879e69.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Jul 10, 2016

GCE e2e build/test passed for commit c879e69.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 00d00cd into kubernetes:master Jul 10, 2016
@dims dims deleted the fix-issue-26303 branch November 16, 2017 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.