-
Notifications
You must be signed in to change notification settings - Fork 40.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
federation: Adding a tool to generate docs for federation apiserver and controller manager #26313
Conversation
Adding label:do-not-merge because PR changes docs prohibited to auto merge |
@kubernetes/docs-review-team Is the do-not-merge label correct? |
the bot is correct |
@eparis since the docs are auto-generated, should the bot allow this PR to be merged but keep the kind/old-docs label like how it treats |
Discussed this with @bgrant0607 and he agreed that it is fine to add autogenerated docs to this repo. We will need to manually merge the PR. As @janetkuo said, it will be good to make the bot smarter to recognize these auto generated docs and handle them as a special case. |
GCE e2e build/test passed for commit 060e537. |
sorry, I completely missed they are auto-generated. We need to update https://github.com/kubernetes/contrib/blob/master/mungegithub/block-path.yaml |
@eparis Thanks for fixing the bot! |
Adding label:do-not-merge because PR changes docs prohibited to auto merge |
@eparis Do we need to do something for kubernetes-retired/contrib#1072 to take effect? |
LGTM. blocked until submit-queue is restarted, and i'm not going to restart it since it is making progress. |
@eparis @nikhiljindal this broke the build... fixed in #26400 |
cc @kubernetes/sig-cluster-federation