routecontroller: Add wait.NonSlidingUntil, use it #26301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure the reconciliation loop kicks in again immediately if it takes a loooooong time.
|
cc @krousey |
k8s-github-robot
added
size/M
zmerlynn
added
release-note
|
LGTM with 2 conditions.
|
krousey
added
the
lgtm
This was referenced May 25, 2016
zmerlynn
added
the
priority/important-soon
|
LGTM - thanks! |
|
GCE e2e build/test passed for commit 3ec25c5. |
|
Automatic merge from submit-queue |
| } | ||
|
|
||
| select { | ||
| case <-stopCh: | ||
| return | ||
| case <-time.After(jitteredPeriod): | ||
| case <-t.C: |
There was a problem hiding this comment.
There is a race that can occur here when sliding is true, and jitterPeriod is 0, and a stopCh + t.C are triggered in close succession. #26782 (comment)
/cc @wojtek-t @mikedanese
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
takes a loooooong time.