Log requests to GCE #26170
Merged
Log requests to GCE #26170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmarek
added
lgtm
k8s-github-robot
added
the
size/XS
wojtek-t
force-pushed
the
log_requests_to_gce
branch
from
5c1433d to
16eec92
Compare
k8s-github-robot
removed
the
lgtm
|
GCE e2e build/test passed for commit 16eec923c811a81759ababe7bb745093db263e98. |
zmerlynn
added
the
lgtm
| rl.limiter.Accept() | ||
| // TODO: Reduce verbosity once #26119 is fixed. | ||
| glog.V(1).Infof("GCE api call: %s %s (throttled for %v)", req.Method, req.URL.String(), time.Now().Sub(startTime)) |
There was a problem hiding this comment.
This looks fine, but do we log at V(1) by default or are you proposing to restart the controller?
There was a problem hiding this comment.
It seems that e.g. in GKE by default we don't log on --v=1. So I changed it temporarily to V(0).
I will reduce the verbosity once we understand this.
wojtek-t
force-pushed
the
log_requests_to_gce
branch
from
16eec92 to
55fdc1c
Compare
|
The only change is V(1) -> V(0), so reapplying lgtm. |
wojtek-t
added
lgtm
|
GCE e2e build/test passed for commit 55fdc1c. |
|
This change is pretty trivial - merging manually. |
k8s-github-robot
pushed a commit
that referenced
this pull request
May 26, 2016
Automatic merge from submit-queue GCE provider: Revert rate limits []() This reverts #26140 and #26170. After testing with #26263, #26140 is unnecessary, and we need to be able to prioritize normal GET / POST requests over operation polling requests, which is what the pre-#26140 requests do. c.f. #26119
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #26119
This should simplify debugging what requests we are sending to GCE (and why we are throttled in routecontroller).
@zmerlynn @gmarek