Fixed check in kubectl autoscale. #26162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed check in kubectl autoscale: cpu consumption can be higher than 100%. Fixes kubernetes#25815.
|
cc @janetkuo |
k8s-github-robot
added
size/XS
| if max < 1 || max < min { | ||
| errs = append(errs, fmt.Errorf("--max=MAXPODS is required, and must be at least 1 and --min=MINPODS")) | ||
| } | ||
| if cpu > 100 { | ||
| errs = append(errs, fmt.Errorf("CPU utilization (%%) cannot exceed 100")) |
There was a problem hiding this comment.
Should we keep a warning in here, or just rely on the server-side warning proposed in #18294
There was a problem hiding this comment.
AFAIK, there are no warning logged to output by kubectl. So, I didn't want to introduce them.
|
LGTM 👍 |
jszczepkowski
added
release-note
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test passed for commit 47a5c17. |
|
Automatic merge from submit-queue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed check in kubectl autoscale: cpu consumption can be higher than 100%. Fixes #25815.