Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker: don't set timeout for image pulling requests #26122

Merged
merged 1 commit into from
May 24, 2016
Merged

docker: don't set timeout for image pulling requests #26122

merged 1 commit into from
May 24, 2016

Conversation

yujuhong
Copy link
Contributor

Image pulling can take an arbitrarily long time. Don't set timeout for such requests.

See #26075 (comment)

/cc @Random-Liu

@yujuhong yujuhong added the sig/node Categorizes an issue or PR as relevant to SIG Node. label May 23, 2016
@Random-Liu Random-Liu self-assigned this May 23, 2016
@yujuhong yujuhong added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label May 23, 2016
@yujuhong
Copy link
Contributor Author

Marking p1 so that we don't get confusing flakes/errors in tests. Marking 1.3 because this is a bug that needs to be fixed.

@yujuhong yujuhong added this to the v1.3 milestone May 23, 2016
@Random-Liu Random-Liu added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 23, 2016
@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels May 23, 2016
@yujuhong yujuhong added release-note-none Denotes a PR that doesn't merit a release note. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed release-note-label-needed labels May 23, 2016
@yujuhong
Copy link
Contributor Author

No release note is needed. This is fixing the bug in HEAD. Reapplied lgtm

@yujuhong
Copy link
Contributor Author

/cc @dchen1107

@dchen1107
Copy link
Member

LGTM and thanks for fixing.

@dchen1107 dchen1107 added the kind/bug Categorizes issue or PR as related to a bug. label May 23, 2016
@dchen1107
Copy link
Member

If we logged the pulling progress, we will catch this regression earlier. :-)

@bprashanth
Copy link
Contributor

@k8s-bot test this issue #IGNORE

https://pantheon.corp.google.com/storage/browser/kubernetes-jenkins/pr-logs/pull/26122/kubernetes-pull-build-test-e2e-gce/41628/

logs show me nothing, build failed no tests ran

!!! Error in /var/lib/jenkins/workspace/kubernetes-pull-build-test-e2e-gce@2/hack/e2e-internal/../../cluster/../cluster/gce/../../cluster/gce/../../cluster/../build/../build/common.sh:563
  '"${docker_cmd[@]}"' exited with status 1
Call stack:
  1: /var/lib/jenkins/workspace/kubernetes-pull-build-test-e2e-gce@2/hack/e2e-internal/../../cluster/../cluster/gce/../../cluster/gce/../../cluster/../build/../build/common.sh:563 kube::build::ensure_data_container(...)
  2: /var/lib/jenkins/workspace/kubernetes-pull-build-test-e2e-gce@2/hack/e2e-internal/../../cluster/../cluster/gce/../../cluster/gce/../../cluster/../build/../build/common.sh:573 kube::build::run_build_command(...)
  3: /var/lib/jenkins/workspace/kubernetes-pull-build-test-e2e-gce@2/hack/e2e-internal/../../cluster/../cluster/gce/../../cluster/gce/../../cluster/../build/release.sh:33 main(...)
Exiting with status 1
2016/05/23 18:36:02 e2e.go:206: Error running build-release: exit status 1
2016/05/23 18:36:02 e2e.go:202: Step 'build-release' finished in 18.222247571s
2016/05/23 18:36:02 e2e.go:95: Error building. Aborting.

But build isn't failing because of this pr because other tests passed.

@Random-Liu Random-Liu mentioned this pull request May 24, 2016
Merged
@k8s-bot
Copy link

k8s-bot commented May 24, 2016

GCE e2e build/test passed for commit 77dba96.

@dchen1107
Copy link
Member

Can we have this one merged manually? @mikedanese

@dchen1107 dchen1107 mentioned this pull request May 24, 2016
Closed
@mikedanese mikedanese merged commit 7350897 into kubernetes:master May 24, 2016
@janetkuo janetkuo mentioned this pull request May 26, 2016
Merged
k8s-github-robot pushed a commit that referenced this pull request May 28, 2016
Merge pull request #26145 from Random-Liu/image-pulling-progress
344f26a 
Automatic merge from submit-queue

Kubelet: Periodically reporting image pulling progress in log

Addresses #26075 (comment) and #26122 (comment).

This PR changes kube_docker_client to log pulling progress every *10* seconds. We can't print all progress messages into the log, because there are too many. So I make it report newest progress every 10 seconds to reduce log spam.
If the image pulling is too slow or stuck, we'll see image pulling progress unchanged or changed little overtime.

The following is the result if I set the reporting interval to *1* second.
```
I0524 00:53:26.189086  145099 kube_docker_client.go:252] Pulling image "ubuntu:latest": "17b6a9e179d7: Pulling fs layer "
I0524 00:53:27.189082  145099 kube_docker_client.go:252] Pulling image "ubuntu:latest": "202e40f8bb3a: Download complete "
I0524 00:53:28.189160  145099 kube_docker_client.go:252] Pulling image "ubuntu:latest": "487bffc61de6: Downloading [=>                                                 ] 1.474 MB/48.35 MB"
I0524 00:53:29.189156  145099 kube_docker_client.go:252] Pulling image "ubuntu:latest": "487bffc61de6: Downloading [====>                                              ] 3.931 MB/48.35 MB"
I0524 00:53:30.189089  145099 kube_docker_client.go:252] Pulling image "ubuntu:latest": "487bffc61de6: Downloading [=========>                                         ] 8.847 MB/48.35 MB"
I0524 00:53:31.189089  145099 kube_docker_client.go:252] Pulling image "ubuntu:latest": "487bffc61de6: Downloading [==================>                                ] 18.19 MB/48.35 MB"
I0524 00:53:32.189076  145099 kube_docker_client.go:252] Pulling image "ubuntu:latest": "487bffc61de6: Downloading [=======================================>           ] 38.34 MB/48.35 MB"
I0524 00:53:33.189106  145099 kube_docker_client.go:252] Pulling image "ubuntu:latest": "487bffc61de6: Extracting [=============>                                     ] 12.78 MB/48.35 MB"
I0524 00:53:34.189067  145099 kube_docker_client.go:252] Pulling image "ubuntu:latest": "487bffc61de6: Extracting [==================================>                ] 33.42 MB/48.35 MB"
I0524 00:53:35.189083  145099 kube_docker_client.go:252] Pulling image "ubuntu:latest": "487bffc61de6: Extracting [==================================================>] 48.35 MB/48.35 MB"
I0524 00:53:35.376667  145099 kube_docker_client.go:254] Finish pulling image "ubuntu:latest": "Status: Downloaded newer image for ubuntu:latest"
```

Ref image pulling related issue #19077.

[![Analytics](https://kubernetes-site.appspot.com/UA-36037335-10/GitHub/.github/PULL_REQUEST_TEMPLATE.md?pixel)]()

@yujuhong @dchen1107 
/cc @kubernetes/sig-node
This was referenced Jun 17, 2016
Merged
Merged
k8s-github-robot pushed a commit that referenced this pull request Jun 21, 2016
Merge pull request #27570 from Random-Liu/add-runtime-request-timeout…
ee35555 
…-flag

Automatic merge from submit-queue

Add runtime-request-timeout kubelet flag.

XRef #23563.

Addresses #27388 (comment).

Add a new kubelet flag `runtime-request-timeout`, and set to 2 minutes by default.
Now the flag only affects dockertools, rkt may also want to set request timeout according to the flag. @yifan-gu 

This PR also removed the timeout for all long running operations to avoid issues like #27588 and #26122.

@yujuhong @rrati 
/cc @kubernetes/sig-node 

[![Analytics](https://kubernetes-site.appspot.com/UA-36037335-10/GitHub/.github/PULL_REQUEST_TEMPLATE.md?pixel)]()
@yujuhong yujuhong deleted the no_timeout branch November 7, 2016 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Random-Liu Random-Liu

Labels
kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.
8 participants
@yujuhong @dchen1107 @bprashanth @k8s-bot @mikedanese @googlebot @Random-Liu @k8s-github-robot