Fixing heapster memory requirements. #26109
Merged
+21
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Q-Lee
commented
May 23, 2016
•
Q-Lee
commented
k8s-github-robot
added
size/M
|
@zmerlynn - this fixes the heapster memory usage bug you found |
zmerlynn
added
release-note
zmerlynn
added
lgtm
|
GCE e2e build/test passed for commit 81ee3e2. |
|
Thanks for the fix @Q-Lee I'm oncall today so I'm manually merging it to unblock some tests. |
|
@roberthbailey @Q-Lee @wojtek-t @zmerlynn please fix the breakage to GCI (in cluster/gce/gci/configure-helper.sh). Adding, removing, or renaming a variable in kube-system manifest requires according changes in cluster/gce/gci/configure-helper.sh. Both GCE and GKE CI tests capture the breakage after this PR was merged |
|
@andyzheng0831 - sorry for the problem. Looking now. |
wojtek-t
added a commit
to wojtek-t/kubernetes
that referenced
this pull request
May 24, 2016
wojtek-t
added a commit
that referenced
this pull request
May 24, 2016
Fix GCI after #26109 breakage
|
#26159 should hopefully fix the problem |
|
Yeah - seems to be fixed now. |
k8s-github-robot
pushed a commit
that referenced
this pull request
Jun 1, 2016
Automatic merge from submit-queue Trusty: fix breakage by #26413 and #26109 The code https://github.com/kubernetes/kubernetes/tree/master/cluster/gce/trusty in both master and release-1.2 branches is broken. Although we already switched to using cluster/gce/gci for 1.3 branch, we will still need to maintain the cluster/gce/trusty code as long as release-1.2 branch is not deprecated. I will make a couple of PR and cherry-picks to make cluster/gce/trusty back to normal. This PR is one of them, which will not be cherry picked to release-1.2. @roberthbailey @dchen1107 @fabioy @zmerlynn cc/ @kubernetes/goog-image
mtaufen
pushed a commit
to mtaufen/kubernetes
that referenced
this pull request
Jun 6, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.