Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed metrics api group #26073

Merged
merged 1 commit into from
May 31, 2016
Merged

Removed metrics api group #26073

merged 1 commit into from
May 31, 2016

Conversation

piosz
Copy link
Member

@piosz piosz commented May 23, 2016 

Removed metrics api group

The group is empty and unused. Kubelet Metrics API is defined in Kubelet code. Master Metrics API is defined in Heapster. Removing to avoid the confusion.

Analytics

@piosz piosz added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label May 23, 2016
@piosz piosz added this to the v1.3 milestone May 23, 2016
@piosz
Copy link
Member Author

piosz commented May 23, 2016

cc @caesarxuchao @timstclair

@k8s-github-robot k8s-github-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/new-api size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 23, 2016
@timstclair
Copy link

Thanks for the clean up!

@lavalamp
Copy link
Member

lgtm

@lavalamp lavalamp added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 24, 2016
@piosz
Copy link
Member Author

piosz commented May 25, 2016

Thanks @lavalamp!

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 26, 2016
@wojtek-t
Copy link
Member

@piosz - can you please rebase?

@piosz piosz force-pushed the remove-metrics-group branch from 055d589 to 22dc21d Compare May 31, 2016 07:48
@piosz piosz added the priority/backlog Higher priority than priority/awaiting-more-evidence. label May 31, 2016
@piosz
Copy link
Member Author

piosz commented May 31, 2016

Bumping priority to avoid further rebases.

@k8s-github-robot k8s-github-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 31, 2016
@piosz piosz added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 31, 2016
@piosz
Copy link
Member Author

piosz commented May 31, 2016

@k8s-bot e2e test this issue: #23591

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented May 31, 2016

GCE e2e build/test passed for commit 22dc21d.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit ae1fb82 into kubernetes:master May 31, 2016
@piosz piosz deleted the remove-metrics-group branch May 31, 2016 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lavalamp lavalamp

Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.
7 participants
@piosz @timstclair @lavalamp @wojtek-t @k8s-github-robot @k8s-bot @googlebot