Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove docker-multinode #26031

Merged
merged 1 commit into from
May 27, 2016
Merged

Conversation

luxas
Copy link
Member

@luxas luxas commented May 21, 2016

This guide has moved to kube-deploy.
We don't want this hanging around in v1.3, so let's remove it.

PR for kube-deploy: kubernetes-retired/kube-deploy#12

@mikedanese @johndmulhausen @bgrant0607

@luxas luxas added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. e2e-not-required labels May 21, 2016
@luxas luxas added this to the v1.3 milestone May 21, 2016
@k8s-github-robot
Copy link

Adding label:do-not-merge because PR changes docs prohibited to auto merge
See http://kubernetes.io/editdocs/ for information about editing docs

@k8s-github-robot k8s-github-robot added kind/old-docs size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels May 21, 2016
@luxas
Copy link
Member Author

luxas commented May 21, 2016

@eparis Is there any way to convince the bot we may touch this (for the last time)?

@bgrant0607
Copy link
Member

@luxas Don't worry about the label. We can just merge this by hand.

@bgrant0607
Copy link
Member

@luxas We need to add redirectors to the new location in kubernetes.github.io, also.

@luxas
Copy link
Member Author

luxas commented May 22, 2016

I don't think we should maintain it in two different places.
All scripts in kubernetes.github.io should also be deleted (of course, the commits that have been made should be ported over to kube-deploy), and the docs guide should describe how to use/setup the kube-deploy deployment. The source of truth should be in kube-deploy.

@bgrant0607 Does this sound like a good idea?

@mikedanese
Copy link
Member

I think we should maintain the getting started guide (e.g. just the doc) in kubernets.github.io. That's the location where it is most user visible and discoverable. We can point to that documentation from kube-deploy.

@luxas
Copy link
Member Author

luxas commented May 23, 2016

@k8s-bot e2e test this please github issue: #IGNORE

@bgrant0607 bgrant0607 assigned mikedanese and unassigned bgrant0607 May 24, 2016
@luxas
Copy link
Member Author

luxas commented May 25, 2016

@mikedanese Want to proceed with this one as the kube-deploy PR is in?

@mikedanese mikedanese added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 27, 2016
@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 27, 2016
@mikedanese mikedanese added lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-label-needed labels May 27, 2016
@luxas
Copy link
Member Author

luxas commented May 27, 2016

@k8s-bot unit test this please github issue: #IGNORE

@luxas luxas removed the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label May 27, 2016
@k8s-bot
Copy link

k8s-bot commented May 27, 2016

GCE e2e build/test passed for commit dca3bd5.

@k8s-github-robot
Copy link

Adding label:do-not-merge because PR changes docs prohibited to auto merge
See http://kubernetes.io/editdocs/ for information about editing docs

@k8s-github-robot k8s-github-robot added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label May 27, 2016
@luxas
Copy link
Member Author

luxas commented May 27, 2016

@mikedanese or @k8s-oncall
Mind a manual merge for this as the bot doesn't like the fact we're touching the old docs?

@a-robinson a-robinson removed the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label May 27, 2016
@a-robinson a-robinson merged commit 5bc7ec7 into kubernetes:master May 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants