Scheduledjob e2e #26027

soltysh · 2016-05-21T21:03:38Z

@erictune last element of the scheduledjob puzzle. I think we'll iterate on this once we have all the puzzles in place. This is one of those things that will be allowed to merge after code freeze.

* Introducing ScheduledJobs as described in [the proposal](https://github.com/kubernetes/kubernetes/blob/master/docs/proposals/scheduledjob.md) as part of `batch/v2alpha1` version (experimental feature).

This change is

erictune · 2016-05-23T05:46:40Z

test/e2e/scheduledjob.go

+		err = waitForActiveJobs(f.Client, f.Namespace.Name, scheduledJob.Name, 2)
+		Expect(err).NotTo(HaveOccurred())
+
+		By("Removing scheduledjob")


Should deleting a scheduledJob delete its jobs?

Hmmm... that's something I wasn't sure about, either. With current approach I've decided that at least removing the SJ will not schedule more jobs, especially that the schedule is pretty dense (new job every 5 sec.). The question is do we care about the jobs after the SJ is removed? I'm inclined to say no. Lemme check how deployments treat older RS, if removing those will also remove them.

From my quick skim over the DeploymentReaper it looks like it removes all related ReplicaSets. In that case I'd say yes remove all.

soltysh · 2016-05-24T09:23:59Z

This is blocked by #25952.

janetkuo · 2016-08-04T18:02:25Z

Running all three e2e tests in #29137 gives me

   Expected error:
      <*runtime.notRegisteredErr | 0xc82046c680>: {
          gvk: {Group: "batch", Version: "v1", Kind: "ScheduledJob"},
          t: nil,
      }
      no kind "ScheduledJob" is registered for version "batch/v1"
  not to have occurred

soltysh · 2016-08-04T18:59:10Z

I haven't got a chance to verify this properly at the time of writing. I'll
revisit this while looking at the remaining PRs we have for SJ.

On Aug 4, 2016 8:02 PM, "Janet Kuo" notifications@github.com wrote:

Running all three e2e tests in #29137
#29137 gives me

Expected error:
<*runtime.notRegisteredErr | 0xc82046c680>: {
gvk: {Group: "batch", Version: "v1", Kind: "ScheduledJob"},
t: nil,
}
no kind "ScheduledJob" is registered for version "batch/v1"
not to have occurred

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#26027 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAjLVWylqkGMpxFZUnQtt3k9USTG82Ucks5qcik6gaJpZM4Ij2-x
.

soltysh · 2016-08-08T14:39:29Z

This relies on #30227, I've added option to set the testing group, so no more no kind "ScheduledJob" is registered for version "batch/v1" error 😉
The only problem I have right now is the actual tests, but I'll be working on that and the fact that this group is disabled by default, should I just force enabling everything for e2e, @janetkuo you know by any chance?

janetkuo · 2016-08-09T18:55:14Z

Yes we can enable batch/v2alpha1 in e2e test, but do we also want to test all e2e tests work fine without enabling batch/v2alpha1? @lavalamp may know?

janetkuo · 2016-08-09T19:04:02Z

test/e2e/scheduledjob.go

+)
+
+var _ = framework.KubeDescribe("ScheduledJob", func() {
+	options := framework.FrameworkOptions{


Or can we do something like:

f := framework.NewDefaultFramework("scheduledjob") f.GroupVersion = &unversioned.GroupVersion{Group: batch.GroupName, Version: "v2alpha1"}

I'd propose leave this as is for now, the end goal is to entirely get rid of the unversioned client, then the problem should disappear and SJ is first on my list, but that will be not sooner than 1.5.

janetkuo · 2016-08-10T01:30:59Z

I found a bug in sj controller and you'll need this PR #30327

soltysh · 2016-08-10T14:35:13Z

@kubernetes/sig-testing how can I globally enable batch/v2alpha1 for e2e tests?

soltysh · 2016-08-11T13:16:20Z

Do we need to test that no jobs are running after sj is deleted? (Do we have the reaper already?)

No reaper yet, need to write one. Will work on it tomorrow.

List jobs (in addition to check sj status) when verifying we have correct number of jobs

Done.

Test ReplaceConcurrent (if this takes too much time, can be a follow-up PR)

Done, but I aslo found a bug there, see #30442

I'll rebase this once your PR lands.

janetkuo · 2016-08-11T21:14:49Z

Reading #30442 makes me think that we should verify pods created by jobs as well.

Reviewed 1 of 1 files at r5.
Review status: all files reviewed at latest revision, 5 unresolved discussions.

test/e2e/scheduledjob.go, line 60 [r5] (raw file):

      jobs, err := f.Client.Batch().Jobs(f.Namespace.Name).List(api.ListOptions{})
      Expect(err).NotTo(HaveOccurred())
      Expect(jobs.Items).To(HaveLen(2))

Could there be more than two jobs?

test/e2e/scheduledjob.go, line 233 [r5] (raw file):

// Wait for a new job to appear.
func waitForNewJob(c *client.Client, ns, previousJobName string) error {

Optional: waitForNewJob may be misused by putting expected job name as the last parameter. How about waitForJobReplaced?

test/e2e/scheduledjob.go, line 240 [r5] (raw file):

      }
      if len(jobs.Items) != 1 {
          return false, nil

If there are more than 1 jobs, should we return error?

Comments from Reviewable

soltysh · 2016-08-12T14:55:44Z

Review status: all files reviewed at latest revision, 5 unresolved discussions.

test/e2e/scheduledjob.go, line 60 [r5] (raw file):

Previously, janetkuo (Janet Kuo) wrote…

Could there be more than two jobs?

Yeah, it can, I'll change this check to be >= 2

test/e2e/scheduledjob.go, line 233 [r5] (raw file):

Previously, janetkuo (Janet Kuo) wrote…

Optional: waitForNewJob may be misused by putting expected job name as the last parameter. How about waitForJobReplaced?

Done

test/e2e/scheduledjob.go, line 240 [r5] (raw file):

Previously, janetkuo (Janet Kuo) wrote…

If there are more than 1 jobs, should we return error?

Done

Comments from Reviewable

soltysh · 2016-08-12T14:56:10Z

Reading #30442 makes me think that we should verify pods created by jobs as well.

If you don't mind I'll leave it as a follow up because of that particular issue.

k8s-bot · 2016-08-12T15:46:26Z

GCE e2e build/test passed for commit 783df12.

janetkuo · 2016-08-12T18:42:01Z

Reviewed 1 of 1 files at r6.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable

k8s-github-robot · 2016-08-12T19:51:21Z

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

soltysh · 2016-08-12T20:25:27Z

I'm removing lgtm label, because this needs #30327 first

k8s-bot · 2016-08-12T20:27:07Z

GCE e2e build/test passed for commit 783df12.

k8s-github-robot · 2016-08-12T20:27:32Z

Automatic merge from submit-queue

soltysh · 2016-08-12T20:28:14Z

Apparently it was too late.

girishkalele · 2016-08-12T22:58:16Z

@soltysh The submit queue is blocked since 13:40 due to GKE failures in the ScheduledJob e2e test.
Is the other commit #30327 going to go in soon ?
Otherwise, we should revert this commit till the other goes in ?

janetkuo · 2016-08-12T23:05:35Z

Failure on GKE:

[k8s.io] ScheduledJob
/go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/test/e2e/framework/framework.go:714
  should not schedule new jobs when ForbidConcurrent [It]
  /go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/test/e2e/scheduledjob.go:118

  Expected error:
      <*errors.StatusError | 0xc820bfc300>: {
          ErrStatus: {
              TypeMeta: {Kind: "Status", APIVersion: "v1"},
              ListMeta: {SelfLink: "", ResourceVersion: ""},
              Status: "Failure",
              Message: "the server could not find the requested resource",
              Reason: "NotFound",
              Details: {Name: "", Group: "", Kind: "", Causes: nil, RetryAfterSeconds: 0},
              Code: 404,
          },
      }
      the server could not find the requested resource
  not to have occurred

janetkuo · 2016-08-12T23:52:42Z

Does KUBE_RUNTIME_CONFIG work on GKE cluster? (Trying to figure out why it failed on GKE)

janetkuo · 2016-08-12T23:58:08Z

Maybe set RUNTIME_CONFIG instead?

soltysh · 2016-08-13T16:46:27Z

Maybe set RUNTIME_CONFIG instead?

The pattern I've noticed is that I set KUBE_RUNTIME_CONFIG and the script uses that to set RUNTIME_CONFIG because it might want to add something more to that env. I'll look into GKE scripts and update those accordingly.

googlebot added the cla: yes label May 21, 2016

k8s-github-robot assigned smarterclayton May 21, 2016

erictune reviewed May 23, 2016
View reviewed changes

soltysh mentioned this pull request Jul 4, 2016

CronJobs (previously ScheduledJobs) kubernetes/enhancements#19

Closed

16 tasks

soltysh force-pushed the scheduledjob_e2e branch from 5c9b13f to ea04eb4 Compare August 8, 2016 14:37

soltysh assigned janetkuo and unassigned smarterclayton Aug 8, 2016

janetkuo reviewed Aug 9, 2016
View reviewed changes

k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 10, 2016

soltysh force-pushed the scheduledjob_e2e branch from ea04eb4 to 30785b4 Compare August 10, 2016 15:37

soltysh added 2 commits August 11, 2016 13:06

Allow setting GroupVersion in e2e tests

be928af

Enable batch/v2alpha1 globally for e2e tests

08fa3e8

soltysh force-pushed the scheduledjob_e2e branch from 30785b4 to c0eded3 Compare August 11, 2016 13:14

soltysh added this to the v1.4 milestone Aug 11, 2016

ScheduledJob e2e

783df12

soltysh force-pushed the scheduledjob_e2e branch from c0eded3 to 783df12 Compare August 12, 2016 15:07

janetkuo added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 12, 2016

rmmh mentioned this pull request Aug 12, 2016

lgtm handler: find lgtm comment and add label kubernetes-retired/contrib#1428

Merged

soltysh removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 12, 2016

k8s-github-robot merged commit ac1f8bc into kubernetes:master Aug 12, 2016

soltysh added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 12, 2016

soltysh mentioned this pull request Aug 12, 2016

Use unversioned client in scheduledjobs and set group version to batch/v2alpha1 #30327

Merged

soltysh deleted the scheduledjob_e2e branch August 12, 2016 20:34

girishkalele mentioned this pull request Aug 12, 2016

Revert "Scheduledjob e2e" #30554

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Scheduledjob e2e #26027

Scheduledjob e2e #26027

soltysh commented May 21, 2016 •

edited by k8s-oncall

Loading

erictune May 23, 2016

soltysh May 23, 2016 •

edited

Loading

soltysh May 23, 2016

soltysh commented May 24, 2016

janetkuo commented Aug 4, 2016

soltysh commented Aug 4, 2016

soltysh commented Aug 8, 2016

janetkuo commented Aug 9, 2016

janetkuo Aug 9, 2016

soltysh Aug 10, 2016

janetkuo commented Aug 10, 2016

soltysh commented Aug 10, 2016 •

edited

Loading

soltysh commented Aug 11, 2016

janetkuo commented Aug 11, 2016

soltysh commented Aug 12, 2016

soltysh commented Aug 12, 2016

k8s-bot commented Aug 12, 2016

janetkuo commented Aug 12, 2016

k8s-github-robot commented Aug 12, 2016

soltysh commented Aug 12, 2016

k8s-bot commented Aug 12, 2016

k8s-github-robot commented Aug 12, 2016

soltysh commented Aug 12, 2016

girishkalele commented Aug 12, 2016

janetkuo commented Aug 12, 2016

janetkuo commented Aug 12, 2016

janetkuo commented Aug 12, 2016

soltysh commented Aug 13, 2016

Scheduledjob e2e #26027

Scheduledjob e2e #26027

Conversation

soltysh commented May 21, 2016 • edited by k8s-oncall Loading

erictune May 23, 2016

Choose a reason for hiding this comment

soltysh May 23, 2016 • edited Loading

Choose a reason for hiding this comment

soltysh May 23, 2016

Choose a reason for hiding this comment

soltysh commented May 24, 2016

janetkuo commented Aug 4, 2016

soltysh commented Aug 4, 2016

soltysh commented Aug 8, 2016

janetkuo commented Aug 9, 2016

janetkuo Aug 9, 2016

Choose a reason for hiding this comment

soltysh Aug 10, 2016

Choose a reason for hiding this comment

janetkuo commented Aug 10, 2016

soltysh commented Aug 10, 2016 • edited Loading

soltysh commented Aug 11, 2016

janetkuo commented Aug 11, 2016

soltysh commented Aug 12, 2016

soltysh commented Aug 12, 2016

k8s-bot commented Aug 12, 2016

janetkuo commented Aug 12, 2016

k8s-github-robot commented Aug 12, 2016

soltysh commented Aug 12, 2016

k8s-bot commented Aug 12, 2016

k8s-github-robot commented Aug 12, 2016

soltysh commented Aug 12, 2016

girishkalele commented Aug 12, 2016

janetkuo commented Aug 12, 2016

janetkuo commented Aug 12, 2016

janetkuo commented Aug 12, 2016

soltysh commented Aug 13, 2016

soltysh commented May 21, 2016 •

edited by k8s-oncall

Loading

soltysh May 23, 2016 •

edited

Loading

soltysh commented Aug 10, 2016 •

edited

Loading