Add missing dependency google.golang.org/api/dns #26026

ghost · 2016-05-21T21:00:05Z

Add missing dependency:

google.golang.org/api/dns

to vendor/

madhusudancs · 2016-05-22T04:09:42Z

Looks like a trivial vendored code addition/update. LGTM.

ghost · 2016-05-22T04:40:30Z

Looks like a license failure on one of the dependencies....

FAILED   ./hack/../hack/verify-godep-licenses.sh    23s
Verifying ./hack/../hack/verify-godeps.sh
Checking for 'Godeps/' changes against 'origin/master'
Starting to download all kubernetes godeps. This takes a while
Download finished
Your Godeps.json is different:
--- /go/src/k8s.io/kubernetes/Godeps/Godeps.json    2016-05-21 14:02:49.443328202 -0700
+++ /tmp/gopath.JAvXZL/src/k8s.io/kubernetes/Godeps/Godeps.json 2016-05-21 14:26:40.834138057 -0700
@@ -724,11 +724,6 @@
            "Rev": "7c47e2558a0bbbaba9ecab06bc6681e73028a28a"
        },
        {
-           "ImportPath": "github.com/emicklei/go-restful/examples/msgpack",
-           "Comment": "v1.2-54-g7c47e25",
-           "Rev": "7c47e2558a0bbbaba9ecab06bc6681e73028a28a"
-       },
-       {
            "ImportPath": "github.com/emicklei/go-restful/log",
            "Comment": "v1.2-54-g7c47e25",
            "Rev": "7c47e2558a0bbbaba9ecab06bc6681e73028a28a"
@@ -2019,10 +2014,6 @@
            "Rev": "4300f6b0c8a7f09e521dd0af2cee27e28846e037"
        },
        {
-           "ImportPath": "google.golang.org/api/dns/v1",
-           "Rev": "4300f6b0c8a7f09e521dd0af2cee27e28846e037"
-       },
-       {
            "ImportPath": "google.golang.org/api/gensupport",
            "Rev": "4300f6b0c8a7f09e521dd0af2cee27e28846e037"
        },
@@ -2100,16 +2091,6 @@
            "Rev": "20b71e5b60d756d3d2f80def009790325acc2b23"
        },
        {
-           "ImportPath": "gopkg.in/vmihailenco/msgpack.v2",
-           "Comment": "v2.5.1",
-           "Rev": "005134bfb4bf69b74e05382eddacea6a4585e4aa"
-       },
-       {
-           "ImportPath": "gopkg.in/vmihailenco/msgpack.v2/codes",
-           "Comment": "v2.5.1",
-           "Rev": "005134bfb4bf69b74e05382eddacea6a4585e4aa"
-       },
-       {
            "ImportPath": "gopkg.in/yaml.v2",
            "Rev": "a83829b6f1293c91addabc89d0571c246397bbf4"
        },
Removing /tmp/gopath.JAvXZL
FAILED   ./hack/../hack/verify-godeps.sh    508s

ghost · 2016-05-22T20:41:44Z

I'm not sure how to resolve this error. @brendandburns ? @lavalamp ?

ghost · 2016-05-23T05:11:35Z

@nikhiljindal FYI, as you're doing such a marvellous job of shepherding the cluster federation PR's through the pipeline.

ghost · 2016-05-23T21:25:29Z

Blocked on #26105

…ilenco/msgpack.v2/ to vendor/

…eran hack/godep-save.sh

…pack.v2

k8s-bot · 2016-05-24T20:34:01Z

GCE e2e build/test failed for commit a031768.

Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake.

ghost · 2016-05-24T21:22:21Z

So the godep licenses are apparently out of date. But when I run hack/update-godep-licenses.sh it just crashes. I'll have to debug that.

$ ./hack/update-godep-licenses.sh --create-missing
./hack/update-godep-licenses.sh: line 183: declare: -A: invalid option
declare: usage: declare [-afFirtx] [-p] [name[=value] ...]
!!! Error in ./hack/update-godep-licenses.sh:183
  'declare -Ag FILE_CONTENT' exited with status 2
Call stack:
  1: ./hack/update-godep-licenses.sh:183 main(...)
Exiting with status 1

Your godep licenses file is out of date. Run hack/update-godep-licenses.sh --create-missing and commit the results.
--- /go/src/k8s.io/kubernetes/Godeps/LICENSES   2016-05-24 12:45:53.454825113 -0700
+++ /go/src/k8s.io/kubernetes/_tmp/kube-godep-licenses.4sRQGK/Godeps/LICENSES   2016-05-24 13:04:04.306854538 -0700
@@ -64925,6 +64925,38 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE


 ================================================================================
+= vendor/google.golang.org/api/dns/v1 licensed under: =
+
+Copyright (c) 2011 Google Inc. All rights reserved.
+
+Redistribution and use in source and binary forms, with or without
+modification, are permitted provided that the following conditions are
+met:
+
+   * Redistributions of source code must retain the above copyright
+notice, this list of conditions and the following disclaimer.
+   * Redistributions in binary form must reproduce the above
+copyright notice, this list of conditions and the following disclaimer
+in the documentation and/or other materials provided with the
+distribution.
+   * Neither the name of Google Inc. nor the names of its
+contributors may be used to endorse or promote products derived from
+this software without specific prior written permission.
+
+THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+"AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+
+================================================================================
 = vendor/google.golang.org/api/gensupport licensed under: =

 Copyright (c) 2011 Google Inc. All rights reserved.
Removing workspace: /go/src/k8s.io/kubernetes/_tmp/kube-godep-licenses.4sRQGK
FAILED   ./hack/../hack/verify-godep-licenses.sh    20s
Verifying ./hack/../hack/verify-godeps.sh
Checking for 'Godeps/' changes against 'origin/master'
Starting to download all kubernetes godeps. This takes a while
Download finished
Your Godeps.json is different:
--- /go/src/k8s.io/kubernetes/Godeps/Godeps.json    2016-05-24 12:45:53.442825113 -0700
+++ /tmp/gopath.Se60P8/src/k8s.io/kubernetes/Godeps/Godeps.json 2016-05-24 13:07:53.414860846 -0700
@@ -2043,10 +2044,6 @@
            "Rev": "4300f6b0c8a7f09e521dd0af2cee27e28846e037"
        },
        {
-           "ImportPath": "google.golang.org/api/dns/v1",
-           "Rev": "4300f6b0c8a7f09e521dd0af2cee27e28846e037"
-       },
-       {
            "ImportPath": "google.golang.org/api/gensupport",
            "Rev": "4300f6b0c8a7f09e521dd0af2cee27e28846e037"
        },
Removing /tmp/gopath.Se60P8
FAILED   ./hack/../hack/verify-godeps.sh    266s

lavalamp · 2016-05-24T21:31:29Z

@quinton-hoole I noticed this problem a couple days ago and managed to make #26008, which is now out of date. I didn't have time to figure out what was going on.

ghost · 2016-05-24T23:03:09Z

@goltermann @karlkfi FYI - godep license checks and license regenerator seems to be broken. To unblock the release, I'm going to temporarily disable it. Does anyone actually understand what this is for, and what it's supposed to do?

goltermann · 2016-05-24T23:11:18Z

It's definitely used by Google for GKE - we need to verify that all godeps are using an appropriate license for us to release GKE containing a new minor version of Kubernetes.

karlkfi · 2016-05-25T02:28:07Z

@quinton-hoole: declare: -A: invalid option means your bash is old. If you want it to be more friendly you could add a bash version check at the top of the file.

Both hack/verify-godeps.sh and hack/verify-godep-licenses.sh are failing. So it's probably related. Fix the out of date godeps and then run hack/update-godep-licenses.sh --create-missing and commit the results.

The problem is that godeps frequently become out of date on master and then whoever makes a new PR gets to fix it, even if they didn't change any godeps.

ghost · 2016-05-25T02:54:16Z

Thanks Karl. I sorted it out in the linked PR.
On May 24, 2016 7:29 PM, "Karl Isenberg" notifications@github.com wrote:

@quinton-hoole https://github.com/quinton-hoole: declare: -A: invalid
option means your bash is old. If you want it to be more friendly you
could add a bash version check at the top of the file.

Both hack/verify-godeps.sh and hack/verify-godep-licenses.sh are failing.
So it's probably related. Fix the out of date godeps and then run hack/update-godep-licenses.sh
--create-missing and commit the results.

The problem is that godeps frequently become out of date on master and
then whoever makes a new PR gets to fix it, even if they didn't change any
godeps.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#26026 (comment)

ghost · 2016-05-25T03:23:13Z

Apparently not quite. Still failing in #26020, but for different reasons now.

ghost · 2016-05-26T20:31:54Z

Blocked on #26348

ghost · 2016-05-27T22:32:59Z

Closing in favor of #26020

ghost added team/control-plane labels May 21, 2016

ghost added this to the v1.3 milestone May 21, 2016

ghost assigned madhusudancs May 21, 2016

googlebot added the cla: yes label May 21, 2016

ghost mentioned this pull request May 21, 2016

Google Cloud DNS dnsprovider - replacement for #25389 #26020

Merged

k8s-github-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. release-note-label-needed labels May 21, 2016

madhusudancs added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 22, 2016

k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 22, 2016

ghost added release-note-none Denotes a PR that doesn't merit a release note. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels May 22, 2016

k8s-github-robot removed the release-note-label-needed label May 22, 2016

This was referenced May 23, 2016

Removing unreferenced code in github/com/emicklei #26105

Merged

Federation service controller #26034

Merged

Quinton Hoole added 3 commits May 24, 2016 11:52

Add missing dependencies google.golang.org/api/dns and gopkg.in/vmiha…

4129a85

…ilenco/msgpack.v2/ to vendor/

Rebased against #26105, which removes unneeded dependency, and then r…

6912c78

…eran hack/godep-save.sh

Removed unnecessary vendor dependency vendor/gopkg.in/vmihailenco/msg…

a031768

…pack.v2

ghost changed the title ~~Add missing dependencies google.golang.org/api/dns and gopkg.in/vmiha…~~ Add missing dependency google.golang.org/api/dns May 24, 2016

Changed to apparently standard godep version 69.

b3fe951

ghost added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels May 24, 2016

ghost closed this May 27, 2016

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add missing dependency google.golang.org/api/dns #26026

Add missing dependency google.golang.org/api/dns #26026

ghost commented May 21, 2016 •

edited by ghost

Loading

madhusudancs commented May 22, 2016

ghost commented May 22, 2016

ghost commented May 22, 2016

ghost commented May 23, 2016

ghost commented May 23, 2016

k8s-bot commented May 24, 2016

ghost commented May 24, 2016

lavalamp commented May 24, 2016

ghost commented May 24, 2016

goltermann commented May 24, 2016

karlkfi commented May 25, 2016

ghost commented May 25, 2016

ghost commented May 25, 2016

ghost commented May 26, 2016

ghost commented May 27, 2016

Add missing dependency google.golang.org/api/dns #26026

Add missing dependency google.golang.org/api/dns #26026

Conversation

ghost commented May 21, 2016 • edited by ghost Loading

madhusudancs commented May 22, 2016

ghost commented May 22, 2016

ghost commented May 22, 2016

ghost commented May 23, 2016

ghost commented May 23, 2016

k8s-bot commented May 24, 2016

ghost commented May 24, 2016

lavalamp commented May 24, 2016

ghost commented May 24, 2016

goltermann commented May 24, 2016

karlkfi commented May 25, 2016

ghost commented May 25, 2016

ghost commented May 25, 2016

ghost commented May 26, 2016

ghost commented May 27, 2016

ghost commented May 21, 2016 •

edited by ghost

Loading