Allow running test-cmd on osx #25981
Merged
+18
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-github-robot
added
size/S
| @@ -310,7 +320,7 @@ runTests() { | |||
| kubectl config set clusters.test-cluster.certificate-authority-data "$cert_data" --set-raw-bytes | |||
| r_writen=$(kubectl config view --raw -o jsonpath='{.clusters[?(@.name == "test-cluster")].cluster.certificate-authority-data}') | |||
|
|
|||
| encoded=$(echo -n "$cert_data" | base64 --wrap=0) | |||
| encoded=$(echo -n "$cert_data" | base64) | |||
There was a problem hiding this comment.
--wrap=0 seems important here; why get rid of it?
There was a problem hiding this comment.
it's nonstandard, so it breaks on osx, and it's unnecessary, because the go base64 decoder skips newlines
ikehz
added
the
release-note-none
ikehz
added
the
lgtm
|
LGTM |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test passed for commit 33ae2b8. |
|
Automatic merge from submit-queue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.