Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ScheduledJob controller #25952

Closed
wants to merge 7 commits into from
Closed

ScheduledJob controller #25952

wants to merge 7 commits into from

Conversation

erictune
Copy link
Member

No description provided.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@erictune erictune force-pushed the sj-controller-bits branch from 0540581 to 5c87785 Compare May 20, 2016 08:10
@erictune
Copy link
Member Author

@soltysh not done, but coming along.

@soltysh
Copy link
Contributor

soltysh commented May 20, 2016

Awesome, I'll try to look into it later today. Big thanks and I owe you a lot of 🍻 when we meet.

@k8s-github-robot k8s-github-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/new-api size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 20, 2016
@soltysh soltysh assigned soltysh and unassigned derekwaynecarr May 20, 2016
@erictune erictune force-pushed the sj-controller-bits branch 2 times, most recently from 03e3550 to 7a2b76b Compare May 22, 2016 05:51
@googlebot
Copy link

CLAs look good, thanks!

@k8s-github-robot k8s-github-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/new-api size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 22, 2016
@erictune erictune added this to the v1.3 milestone May 23, 2016
@erictune erictune force-pushed the sj-controller-bits branch from ce4be0d to 6f4f26d Compare May 23, 2016 17:40
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@k8s-github-robot k8s-github-robot added kind/old-docs size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 23, 2016
@erictune erictune added the release-note-none Denotes a PR that doesn't merit a release note. label May 23, 2016
@erictune
Copy link
Member Author

I tried to debug the above issues some more last night. I added some comments but didn't find a solution.

erictune
erictune reviewed May 24, 2016
View reviewed changes
pkg/client/clientset_generated/internalclientset/typed/batch/unversioned/batch_client.go
copyGroupVersion := g.GroupVersion
config.GroupVersion = &copyGroupVersion
//}
// Do we need something like this:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@caesarxuchao You had suggested that I set the GroupVersion in the config. But the config does not have a .Version field, and it overrides the setting in the groupVersion in setConfigDefaults at pkg/client/clientset_generated/internalclientset/typed/batch//unversioned/batch_client.go:48

Also, do you know what the "until we fix the config" comment above means?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember that line now. We never properly fix the setConfigDefaults because we haven't had multiple versions for a long time. I'll take a look later today. If it's urgent, you can try @krousey to see if he can get to it earlier than me.

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 24, 2016
@goltermann
Copy link
Contributor

@erictune This PR has the v1.3 milestone tag applied, but hasn't been touched in a week or more. We will cut Beta and branch on June 10. Please either close, finish off, get an LGTM or rebase this as needed to make sure it makes its way into 1.3.

@erictune erictune modified the milestones: next-candidate, v1.3 Jun 7, 2016
@soltysh soltysh mentioned this pull request Jul 4, 2016
Closed
16 tasks
@erictune erictune modified the milestones: v1.4, next-candidate Jul 7, 2016
@soltysh soltysh mentioned this pull request Jul 14, 2016
Closed
@erictune erictune force-pushed the sj-controller-bits branch from 6dc1123 to f609399 Compare July 14, 2016 16:58
@k8s-github-robot k8s-github-robot removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. kind/old-docs labels Jul 14, 2016
@k8s-bot
Copy link

k8s-bot commented Jul 14, 2016

GCE e2e build/test failed for commit f609399.

Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake.

@janetkuo janetkuo mentioned this pull request Jul 18, 2016
Merged
@k8s-github-robot k8s-github-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 21, 2016
@k8s-github-robot
Copy link

@erictune PR needs rebase

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 25, 2016
@soltysh
Copy link
Contributor

soltysh commented Jul 28, 2016

Closing in favor of #29137.

@soltysh soltysh closed this Jul 28, 2016
k8s-github-robot pushed a commit that referenced this pull request Aug 6, 2016
Merge pull request #29137 from janetkuo/scheduledjob-controller
9083ee9 
Automatic merge from submit-queue

Scheduledjob controller

Supersedes #25952; first 7 commits come from #25816

<!--
Checklist for submitting a Pull Request

Please remove this comment block before submitting.

1. Please read our [contributor guidelines](https://github.com/kubernetes/kubernetes/blob/master/CONTRIBUTING.md).
2. See our [developer guide](https://github.com/kubernetes/kubernetes/blob/master/docs/devel/development.md).
3. If you want this PR to automatically close an issue when it is merged,
   add `fixes #<issue number>` or `fixes #<issue number>, fixes #<issue number>`
   to close multiple issues (see: https://github.com/blog/1506-closing-issues-via-pull-requests).
4. Follow the instructions for [labeling and writing a release note for this PR](https://github.com/kubernetes/kubernetes/blob/master/docs/devel/pull-requests.md#release-notes) in the block below.
-->

```release-note
```
@erictune erictune deleted the sj-controller-bits branch August 8, 2017 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@soltysh soltysh

Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.
10 participants
@erictune @googlebot @soltysh @maclof @k8s-github-robot @goltermann @k8s-bot @caesarxuchao @deads2k @derekwaynecarr