Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle cAdvisor partial failures #25933

Merged
merged 1 commit into from
May 22, 2016

Conversation

timstclair
Copy link

Kubernetes side of google/cadvisor#1286

Partially fixes #25131

(Depends on cAdvisor Godeps bump #25914)

/cc @kubernetes/sig-node

@timstclair timstclair added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label May 20, 2016
@timstclair timstclair added this to the v1.3 milestone May 20, 2016
@k8s-github-robot k8s-github-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 20, 2016
@timstclair
Copy link
Author

Fixed import (goimports fail)

@timstclair timstclair force-pushed the subcontainers branch 2 times, most recently from 53b6fa0 to a7b08bf Compare May 20, 2016 01:52
@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 20, 2016
@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 20, 2016
@vishh
Copy link
Contributor

vishh commented May 20, 2016

LGTM

@vishh vishh added do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels May 20, 2016
@vishh
Copy link
Contributor

vishh commented May 20, 2016

@timstclair Can you remove the do-not-merge label once #25914 is merged?

@timstclair
Copy link
Author

Removing do-not-merge since this is just a no-op without the dependent PR

@timstclair timstclair removed the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label May 21, 2016
@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented May 22, 2016

GCE e2e build/test passed for commit b05b419.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit f1e528e into kubernetes:master May 22, 2016
@timstclair timstclair deleted the subcontainers branch August 31, 2016 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pods missing on Grafana/InfluxDB dashboards
6 participants