-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle cAdvisor partial failures #25933
Merged
Merged
+32
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timstclair
added
the
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
label
May 20, 2016
k8s-github-robot
added
the
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
label
May 20, 2016
Fixed import ( |
timstclair
force-pushed
the
subcontainers
branch
2 times, most recently
from
May 20, 2016 01:52
53b6fa0
to
a7b08bf
Compare
k8s-github-robot
added
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
and removed
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
labels
May 20, 2016
k8s-github-robot
added
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
and removed
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
labels
May 20, 2016
LGTM |
vishh
added
do-not-merge
DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed.
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
labels
May 20, 2016
@timstclair Can you remove the |
Removing do-not-merge since this is just a no-op without the dependent PR |
timstclair
removed
the
do-not-merge
DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed.
label
May 21, 2016
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
GCE e2e build/test passed for commit b05b419. |
Automatic merge from submit-queue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kubernetes side of google/cadvisor#1286
Partially fixes #25131
(Depends on cAdvisor Godeps bump #25914)
/cc @kubernetes/sig-node