Use strategic patch to replace changeCause in patch command #25876
Conversation
|
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. Otherwise, if this message is too spammy, please complain to ixdy. |
2 similar comments
|
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. Otherwise, if this message is too spammy, please complain to ixdy. |
|
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. Otherwise, if this message is too spammy, please complain to ixdy. |
k8s-github-robot
added
size/S
dshulyak
changed the title
|
@deads2k May I ask for review? |
| resource.NewHelper(client, mapping).Replace(namespace, name, false, patchedObject) | ||
| patch, err := cmdutil.ChangeResourcePatch(info, f.Command()) | ||
| if err == nil { | ||
| helper.Patch(info.Namespace, info.Name, api.StrategicMergePatchType, patch) |
There was a problem hiding this comment.
Add a comment about suppressing the failure and why its good to do that.
|
ok to test |
janetkuo
added
release-note-none
|
The author of this PR is not in the whitelist for merge, can one of the admins add the 'ok-to-merge' label? |
|
@dshulyak probably a flake, rebase on master and re-push to kick it. I didn't see anything too obvious in the issue list, so it may already be resolved. |
|
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. Otherwise, if this message is too spammy, please complain to ixdy. |
deads2k
added
lgtm
|
GCE e2e build/test failed for commit d495c283497d30c36d4a7afe9a85120fa9d496fb. Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake. |
|
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. Otherwise, if this message is too spammy, please complain to ixdy. |
k8s-github-robot
added
the
needs-rebase
k8s-github-robot
removed
lgtm
deads2k
added
the
lgtm
|
GCE e2e build/test passed for commit d81f7a0. |
|
GCE e2e build/test passed for commit d81f7a0. |
|
Automatic merge from submit-queue |
This is partial rework of 11da9a7
StrategicPatch will be used to update changeCause but failure wont affect command result
fixes: #24858