Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

@simonswine did you use the cherry pick pull script to create this pr?

@simonswine thanks for the fix -- should this get a release note?

#25873 should have a release note. I've also marked it as a cherry pick candidate.

@roberthbailey no this was a manual git cherry-pick

I wasn't really aware of that

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

@simonswine: This hasn't even been LGTM'd on master yet, so it may unfortunately miss the 1.2.5 cut unless you can get this hustled through. We can't take the c-p unless the original is in and tested as well. In general, we'd vastly prefer if you use the automated script, but we're also now hitting deadline so we could let this one slide.

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

Are we waiting on this one for 1.2.5?

No. The base PR hasn't merged yet still.

On Mon, Jun 27, 2016 at 10:22 AM, David McMahon notifications@github.com
wrote:

Are we waiting on this one for 1.2.5?

—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
#25874 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AEtqgM7Wec3PWgIiMBv-i-DbBUPZd7Ywks5qQAa7gaJpZM4IiQlZ
.

@zmerlynn @david-mcmahon: The base PR has been merged meanwhile (is in 1.3.0), can we merged this back to 1.2? (only if there is a plan to release 1.2.6)

@roberthbailey can comment on the future of 1.2 at this point.

We can merge it into the 1.2 release branch, but we don't currently have any plans to cut another release from the branch. We can if someone wants one though.

ok to test
@k8s-bot test this

pr builder appears to be missing, activating due to 'lgtm' label.

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

GCE e2e build/test failed for commit 121299e.

• Test Results
• Build Log
• Test Artifacts
• Internal Jenkins Results

Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake.

Commit found in the "release-1.2" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.