-
Notifications
You must be signed in to change notification settings - Fork 40.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update evanphx/json-patch to newest version #25866
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. Otherwise, if this message is too spammy, please complain to ixdy. |
2 similar comments
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. Otherwise, if this message is too spammy, please complain to ixdy. |
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. Otherwise, if this message is too spammy, please complain to ixdy. |
I signed it! |
CLAs look good, thanks! |
ok to test |
@deads2k since you've been reviewing patch stuff. |
lgtm |
@k8s-bot test this Tests are more than 96 hours old. Re-running tests. |
GCE e2e build/test passed for commit b8d4eac. |
@nebril PR needs rebase |
It seems like this library has been updated in master before this got merged. Closing this one. |
It still returns 500 in the situation described in the issue, but the error message is much more comprehensible.
I am getting following message in response to request described in the issue.
"jsonpatch replace operation does not apply: doc is missing path: spec/template/spec/containers/0/image"
fixes #25417