Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the bug of the "removePod" function in node_info.go #25863

Merged
merged 2 commits into from
May 22, 2016
Merged

Fix the bug of the "removePod" function in node_info.go #25863

merged 2 commits into from
May 22, 2016

Conversation

ping035627
Copy link
Contributor

It should reduce the resource data after finding the pod in the pods, because perhaps no corresponding pod in the pods of the node, at this time it shouldn't reduce the resource data of the node.

@ping035627
Fix the bug of the "removePod" function in node_info.go
85f1e0e 
It should reduce the resource data after finding the pod in the pods, because perhaps no corresponding pod in the pods of the node, at this time it shouldn't reduce the resource data of the node.
@k8s-bot
Copy link

k8s-bot commented May 19, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

2 similar comments
@k8s-bot
Copy link

k8s-bot commented May 19, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

@k8s-bot
Copy link

k8s-bot commented May 19, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-label-needed labels May 19, 2016
@ping035627
Copy link
Contributor Author

@davidopp
fix bug, can test? thanks.

@ping035627
Copy link
Contributor Author

@wojtek-t
fix bug, can test? thanks

@wojtek-t
Copy link
Member

Seems test didn't start

@k8s-bot test this please github issue: #IGNORE

@ping035627 ping035627 mentioned this pull request May 20, 2016
Closed
@ping035627
Copy link
Contributor Author

@k8s-bot test this issue: #25936

@ping035627
Copy link
Contributor Author

@wojtek-t
need "ok to test", thanks

@hongchaodeng
Copy link
Contributor

Add a test?

@ping035627
Copy link
Contributor Author

Seems test didn't start.

@davidopp davidopp added release-note-none Denotes a PR that doesn't merit a release note. ok-to-merge and removed release-note-label-needed labels May 21, 2016
@davidopp davidopp added this to the v1.3 milestone May 21, 2016
@davidopp
Copy link
Member

LGTM

@davidopp davidopp added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 21, 2016
@davidopp
Copy link
Member

ok to test

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented May 22, 2016

GCE e2e build/test passed for commit 901011f.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 529135d into kubernetes:master May 22, 2016
@ping035627 ping035627 deleted the ping035627-patch-2 branch September 19, 2016 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@davidopp davidopp

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.
7 participants
@ping035627 @k8s-bot @wojtek-t @hongchaodeng @davidopp @k8s-github-robot @googlebot