Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add metrics support for a GCE PD, EC2 EBS & Azure File volumes #25852

Merged
merged 1 commit into from
May 26, 2016
Merged

Add metrics support for a GCE PD, EC2 EBS & Azure File volumes #25852

merged 1 commit into from
May 26, 2016
+163 −122

Conversation

vishh
Copy link
Contributor

@vishh vishh commented May 19, 2016

Added filesystem metrics for GCE PD, EC2 ebs & Azure file

Fixes #25840

cc @thockin

@vishh vishh added sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/node Categorizes an issue or PR as relevant to SIG Node. labels May 19, 2016
@k8s-github-robot k8s-github-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note-label-needed labels May 19, 2016
@pwittrock
Copy link
Member

Looks like this fails to compile

pwittrock
pwittrock reviewed May 19, 2016
View reviewed changes
pkg/volume/metrics_statfs.go

var _ MetricsProvider = &metricsStatFS{}

// metricsStatFS represents a MetricsProvider that calculates the used and available
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plz update the comment so say it uses statfs to get the aggregate usage metrics for the device.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@vishh vishh force-pushed the network-volumes branch from 4df8ef0 to 444bec1 Compare May 19, 2016 23:01
@vishh
Copy link
Contributor Author

vishh commented May 19, 2016

@pwittrock PTAL

@vishh vishh changed the title Add metrics support for a few network based volumes. Add metrics support for a GCE PD, EC2 EBS & Azure File volumes May 19, 2016
@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 20, 2016
@vishh vishh force-pushed the network-volumes branch 2 times, most recently from 249f1a0 to 2ca4897 Compare May 20, 2016 00:13
@vishh vishh removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 20, 2016
@vishh vishh closed this May 20, 2016
@vishh vishh reopened this May 20, 2016
@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 20, 2016
@vishh vishh force-pushed the network-volumes branch from 2ca4897 to 1ef9d74 Compare May 20, 2016 00:27
@vishh
Copy link
Contributor Author

vishh commented May 20, 2016

@k8s-bot test unit github issue #IGNORE

@pwittrock pwittrock added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 20, 2016
@pwittrock
Copy link
Member

@k8s-bot test unit github issue #IGNORE

@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 20, 2016
@vishh vishh added release-note Denotes a PR that will be considered when it comes time to generate release notes. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed release-note-label-needed labels May 20, 2016
@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 22, 2016
@vishh
Add metrics support for a few network based volumes.
baa8ac4 
Signed-off-by: Vishnu Kannan <vishnuk@google.com>
@vishh vishh removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 23, 2016
@vishh vishh added this to the v1.3 milestone May 23, 2016
@vishh vishh added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels May 23, 2016
@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 23, 2016
@vishh vishh force-pushed the network-volumes branch from 1ef9d74 to baa8ac4 Compare May 23, 2016 17:12
@k8s-github-robot k8s-github-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 23, 2016
@alex-mohr
Copy link
Contributor

Because submit queue is blocked, I'm going to kick off re-tests of the top 5 PRs in the queue, then merge them if they pass.
@k8s-bot test this please: issue #IGNORE

@k8s-bot
Copy link

k8s-bot commented May 26, 2016

GCE e2e build/test passed for commit baa8ac4.

@alex-mohr alex-mohr merged commit 0a61789 into kubernetes:master May 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pwittrock pwittrock

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.
6 participants
@vishh @pwittrock @alex-mohr @k8s-bot @googlebot @k8s-github-robot