GCE: Enable using gcr.io as a Docker registry mirror. #25841
Conversation
|
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. Otherwise, if this message is too spammy, please complain to ixdy. |
1 similar comment
|
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. Otherwise, if this message is too spammy, please complain to ixdy. |
|
@dchen1107 Can you please take a look at this? |
|
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. Otherwise, if this message is too spammy, please complain to ixdy. |
k8s-github-robot
added
size/S
|
ok to test |
|
This looks ok to me, but I'd like @zmerlynn to take a look as well since he was recently changing a bunch of our scripts to deal with regional gcr registries. @andyzheng0831 - we should enable this for GCI nodes on GCE as well. |
|
@roberthbailey No problem. If this PR will not be cherry picked to release-1.2, I will only make change in cluster/gce/gci but not for cluster/gce/trusty |
k8s-github-robot
added
kind/api-change
|
|
||
| # Decide whether to enable the cache | ||
| if [[ "${ENABLE_DOCKER_REGISTRY_CACHE:-}" == "true" ]]; then | ||
| REGION=$(echo "${ZONE}" | cut -f 1 -d -) |
There was a problem hiding this comment.
Where this env variable "${ZONE}" from? And it is better to use "${ZONE:-}" in case it is unset.
There was a problem hiding this comment.
@andyzheng0831 Added an explanation of the source of the variables (the kube-env metadata value), and added special handling for the ZONE variable being empty.
PTAL
| if [[ "${REGION}" == "europe" ]]; then | ||
| REGION="eu" | ||
| fi | ||
| echo "Enable docker registry cache at region: " $REGION |
roberthbailey
added
ok-to-merge
release-note
roberthbailey
changed the title
roberthbailey
changed the title
ojarjur
force-pushed
the
ojarjur/registry-mirror
branch
from
02ccca0 to
60de7f7
Compare
zmerlynn
added
the
lgtm
This only affects clusters running under GCE.
ojarjur
force-pushed
the
ojarjur/registry-mirror
branch
from
60de7f7 to
338b33f
Compare
k8s-github-robot
removed
the
lgtm
roberthbailey
added
the
lgtm
|
@andyzheng0831 I don't think this one need to cherrypick to 1.2 release branch. |
|
I agree, but we should set it on GCI masters on the master branch. |
|
Is there something else I need to do for this PR? |
|
No, just wait for it to get merged. You can track your PR's progress at http://submit-queue.k8s.io/#/queue |
Can we file an issue to GCI team and assign it to somebody so that it doesn't get lost in emails? |
|
No need to log a separate issue for GCI. For cases like this PR, we can make GCI side change when the original PR is finalized (i.e., marked with lgtm). So, it is the time, I will make a PR for GCI |
|
I will make a PR for GCI config change. As we already switched k8s master to GCI and we are testing it in various places, I think we may encourage k8s developers to make the GCI side change if necessary when they prepare their PRs. I understand people may need some time to know how to do GCI config change and how to test it. But it is better to gradually do it, and we have seen more and more developers are doing it which is pretty good. For GCI config change, please feel free to cc me for review. |
Automatic merge from submit-queue GCI/Trusty: support the Docker registry mirror @roberthbailey @zmerlynn please review it. cc/ @fabioy @dchen1107 @kubernetes/goog-image FYI. cc/ @ojarjur it is very straightforward to add support for GCI, which is pretty much like the change to ContainerVM's configure-vm.sh in your original PR #25841.
|
@ojarjur @roberthbailey @zmerlynn @andyzheng0831 What's needed here? Just prod the test bot along? |
|
Yes. Ironically, the PR that copied this for GCI has already been merged but this one is still sitting. |
|
@k8s-bot test this issue: #IGNORE (the details links for the two failed tests show no output) |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test passed for commit 338b33f. |
|
Automatic merge from submit-queue |
|
Can someone give me more details on this? Is gcr.io a full mirror of docker? |
|
The short answer is that |
This only affects clusters running under GCE.