-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update kubelet limits to be pods/core up to max-pods. #25762
Comments
I agree, but this is a medium-term goal. For 1.3 we are going to leave limits as they were so far (i.e. pods/cluster, nodes/cluster, pods/node). |
@wojtek-t we could probably create a patch that would default off but we-(Red Hat) could leverage. It would be no-op change for upstream, but our customers have much larger and denser nodes that they would like to leverage. Given this would be a 0-feature change for upstream, what is your opinion? /cc @smarterclayton |
Yeah - adding a "by-default" non-active limit sgtm. |
Code is in, we'll just need to update defaults for 1.4 |
@timothysc @rrati @wojtek-t any more work needed for v1.4? |
we've enabled flag over-rides in 1.3, but have not updated defaults for 1.4, so I'm moving out to 1.5. I'd like to prioritize this as a 1.5 action item for @kubernetes/sig-node |
I was pointed that this is correct thread for my question so here I am. |
@timothysc is the changed version of those tests publicly available ? |
We can probably share that data, we do a baseline overhead test @ 250 pods/node on our env. But this will vary based upon the storage layer used by docker, and the docker version itself. /cc @mffiedler |
This needs to be triaged as a release-blocker or not for 1.5 @Random-Liu (or move to 1.6?) @timothysc |
Not sure what we can do for 1.5 at this moment. Moving it to 1.6 |
Knobs are all there sig-node can update defaults as needed. |
Per discussions on @kubernetes/sig-scalability, we should update the advertised maximum pods to be a function of pods/core(default 10) up to a hard cap max-pods (currently 110).
xref: https://docs.google.com/a/bobsplanet.com/document/d/1hEpf25qifVWztaeZPFmjNiJvPo-5JX1z0LSvvVY5G2g/edit?usp=drive_web
/cc @kubernetes/sig-node @rrati
The text was updated successfully, but these errors were encountered: