Bumped Heapster to v1.1.0-beta2 #25739
Merged
+30
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piosz
added
the
release-note-none
|
LGTM |
mwielgus
added
the
lgtm
k8s-github-robot
added
the
size/M
| @@ -40,7 +40,6 @@ spec: | |||
| command: | |||
| - /heapster | |||
| - --source=kubernetes.summary_api:'' | |||
| - --metric_resolution=60s | |||
There was a problem hiding this comment.
Just so I understand, why is this flag being removed?
There was a problem hiding this comment.
I changed it to be 60s by default in Heapster kubernetes-retired/heapster#1164.
There is not much sense to have it different and overwrite in config.
|
LGTM, just one question to help me understand the new config |
|
lgtm |
piosz
force-pushed
the
heapster-1.1.0-beta2
branch
from
c7091be to
eea3a4e
Compare
|
Actually bumped the Heapster. Previously I only changed versions not the image. |
k8s-github-robot
removed
the
lgtm
piosz
added
the
lgtm
|
GCE e2e build/test passed for commit eea3a4e. |
|
flake due to #25897 |
|
@piosz |
k8s-github-robot
removed
the
lgtm
piosz
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @a-robinson @fgrzadkowski @jszczepkowski @Q-Lee