-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add link to diagram of kubectl drain
#25736
Add link to diagram of kubectl drain
#25736
Conversation
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. Otherwise, if this message is too spammy, please complain to ixdy. |
2 similar comments
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. Otherwise, if this message is too spammy, please complain to ixdy. |
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. Otherwise, if this message is too spammy, please complain to ixdy. |
You'll need to generate docs and such: |
95a4789
to
9341d88
Compare
you should also add "fixes kubernetes/website#501" to the PR message. |
Sorry, github didn't send a notification when you re-pushed. Tag me when you update. Also, double check that link. |
9341d88
to
c7f7c0a
Compare
@deads2k, PR is rebased |
The link: http://kubernetes.io/images/docs/kubectl_drain.svg still 404's for me. Should I be seeing something? |
@deads2k I have separate PR to kubernetes.github.io and it doesn't merged yet. Also it hasn't reviews. |
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. Otherwise, if this message is too spammy, please complain to ixdy. |
1 similar comment
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. Otherwise, if this message is too spammy, please complain to ixdy. |
Alright, the link works now. Run the hack/update-all.sh again. #25736 (comment) @bgrant0607 @kubernetes/kubectl Any guidance on providing deep links from CLI help? I've seen products decide in both directions and neither is clearly better in my mind. |
We need to make a consistent decision here for #25810 as well. Adding SVG links to what are effectively |
@smarterclayton I agree consistency is important. We need to think holistically about what we'd like to do with kubectl help. We're collecting ideas here: Among other things, we'll probably need to start to embed formatting. I'm thinking we should write the text in a form (markdown?) that can be post-processed for the various ways in which the text would be published/viewed. |
I don't have particular concerns about the image links. |
Fine with that as well. |
Alright, if I get the choice I'd prefer to include the link. Rebase once more for merge? |
c7f7c0a
to
21b218c
Compare
@deads2k done |
GCE e2e build/test passed for commit c7f7c0a6f58754c47fe3b160eae0ba04cc9bc87b. |
GCE e2e build/test passed for commit 21b218c. |
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
GCE e2e build/test passed for commit 21b218c. |
Automatic merge from submit-queue |
issue kubernetes/website#501