Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to diagram of kubectl drain #25736

Merged

Conversation

andreykurilin
Copy link
Contributor

@k8s-bot
Copy link

k8s-bot commented May 17, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

2 similar comments
@k8s-bot
Copy link

k8s-bot commented May 17, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

@k8s-bot
Copy link

k8s-bot commented May 17, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels May 17, 2016
@deads2k
Copy link
Contributor

deads2k commented May 17, 2016

You'll need to generate docs and such: hack/update-all.sh. If that fails, you can try update-generated-docs.sh, but I'm not certain that will get everything.

@asalkeld
Copy link

you should also add "fixes kubernetes/website#501" to the PR message.

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 10, 2016
@deads2k
Copy link
Contributor

deads2k commented Jun 13, 2016

@andreykurilin PR needs rebase

Sorry, github didn't send a notification when you re-pushed. Tag me when you update. Also, double check that link.

@andreykurilin andreykurilin force-pushed the diagram_kubectl_drain branch from 9341d88 to c7f7c0a Compare June 14, 2016 13:00
@andreykurilin
Copy link
Contributor Author

@deads2k, PR is rebased

@k8s-github-robot k8s-github-robot removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. kind/old-docs labels Jun 14, 2016
@deads2k
Copy link
Contributor

deads2k commented Jun 14, 2016

The link: http://kubernetes.io/images/docs/kubectl_drain.svg still 404's for me. Should I be seeing something?

@andreykurilin
Copy link
Contributor Author

@deads2k I have separate PR to kubernetes.github.io and it doesn't merged yet. Also it hasn't reviews.

see kubernetes/website#521

@k8s-bot
Copy link

k8s-bot commented Jun 14, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

1 similar comment
@k8s-bot
Copy link

k8s-bot commented Jun 15, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

@deads2k
Copy link
Contributor

deads2k commented Jun 15, 2016

Alright, the link works now. Run the hack/update-all.sh again. #25736 (comment)

@bgrant0607 @kubernetes/kubectl Any guidance on providing deep links from CLI help? I've seen products decide in both directions and neither is clearly better in my mind.

@andreykurilin
Copy link
Contributor Author

@deads2k It looks like I do not need to run any updaters. See 1d25410

@smarterclayton
Copy link
Contributor

We need to make a consistent decision here for #25810 as well. Adding SVG links to what are effectively man pages is not the end of the world, but it's an unusual step. Links to help from man pages makes sense, but in our case the help we would be linking to is exactly what is in the man page.

@bgrant0607
Copy link
Member

@smarterclayton I agree consistency is important.

We need to think holistically about what we'd like to do with kubectl help.

We're collecting ideas here:
https://github.com/kubernetes/community/wiki/Roadmap:-kubectl#improve-help--error-messages--output

Among other things, we'll probably need to start to embed formatting. I'm thinking we should write the text in a form (markdown?) that can be post-processed for the various ways in which the text would be published/viewed.

@bgrant0607
Copy link
Member

I don't have particular concerns about the image links.

@smarterclayton
Copy link
Contributor

Fine with that as well.

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 28, 2016
@deads2k
Copy link
Contributor

deads2k commented Jun 29, 2016

I don't have particular concerns about the image links.

Alright, if I get the choice I'd prefer to include the link. Rebase once more for merge?

@andreykurilin andreykurilin force-pushed the diagram_kubectl_drain branch from c7f7c0a to 21b218c Compare June 29, 2016 16:10
@andreykurilin
Copy link
Contributor Author

@deads2k done

@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 29, 2016
@k8s-bot
Copy link

k8s-bot commented Jun 29, 2016

GCE e2e build/test passed for commit c7f7c0a6f58754c47fe3b160eae0ba04cc9bc87b.

@k8s-bot
Copy link

k8s-bot commented Jun 29, 2016

GCE e2e build/test passed for commit 21b218c.

@deads2k deads2k added release-note-none Denotes a PR that doesn't merit a release note. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed release-note-label-needed labels Jun 29, 2016
@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Jun 29, 2016

GCE e2e build/test passed for commit 21b218c.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 3814809 into kubernetes:master Jun 29, 2016
@andreykurilin andreykurilin deleted the diagram_kubectl_drain branch July 1, 2016 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants