Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added enforcing of setting nodes numbers for cluster autoscaler. #25734

Merged
merged 1 commit into from
May 20, 2016
Merged

Added enforcing of setting nodes numbers for cluster autoscaler. #25734

merged 1 commit into from
May 20, 2016
+16 −5

Conversation

jszczepkowski
Copy link
Contributor

@jszczepkowski jszczepkowski commented May 17, 2016 •
edited by fgrzadkowski
Loading 

Incompatible change of kube-up.sh: 
when turning on cluster autoscaler by setting KUBE_ENABLE_NODE_AUTOSCALER=true,
KUBE_AUTOSCALER_MIN_NODES and KUBE_AUTOSCALER_MAX_NODES need to be set.

Added enforcing of setting nodes numbers for cluster autoscaler in kube-up script.

@jszczepkowski
Added enforcing of setting nodes numbers for cluster autoscaler.
858eb03 
Added enforcing of setting nodes numbers for cluster autoscaler in kube-up script.
@jszczepkowski
Copy link
Contributor Author

CC @fgrzadkowski @mwielgus

@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-label-needed labels May 17, 2016
@piosz piosz added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-label-needed labels May 17, 2016
@piosz
Copy link
Member

piosz commented May 17, 2016

LGTM

@piosz piosz added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 17, 2016
@k8s-bot
Copy link

k8s-bot commented May 17, 2016

GCE e2e build/test passed for commit 858eb03.

@k8s-github-robot k8s-github-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 19, 2016
@piosz piosz added this to the v1.3 milestone May 19, 2016
@fgrzadkowski fgrzadkowski merged commit 2f2b7c8 into kubernetes:master May 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@piosz piosz

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.
6 participants
@jszczepkowski @piosz @k8s-bot @googlebot @fgrzadkowski @k8s-github-robot