Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hyperkube's layer caching, and remove --make-symlinks at build time #25693

Merged
merged 1 commit into from
May 17, 2016
Merged

Fix hyperkube's layer caching, and remove --make-symlinks at build time #25693

merged 1 commit into from
May 17, 2016

Conversation

luxas
Copy link
Member

@luxas luxas commented May 16, 2016

@david-mcmahon This is required before you release. Explanation in the code.

@luxas luxas added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. e2e-not-required labels May 16, 2016
@david-mcmahon david-mcmahon added lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels May 16, 2016
@david-mcmahon
Copy link
Contributor

I see this also contains #25684. If this one gets in first I'll close it.

@k8s-github-robot k8s-github-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 16, 2016
@luxas
Copy link
Member Author

luxas commented May 16, 2016

Oops, didn't mean to include #25684, but it was required when I tested it, and then I forgot to remove it before the commit. I may remove it so we don't get any merge conflicts.

The layer patch is saving us ~130 MB/image when pulling, which is a lot

@luxas luxas mentioned this pull request May 16, 2016
Merged
@luxas
Copy link
Member Author

luxas commented May 16, 2016

Fixed so it doesn't touch #25684, I think #25684 is gonna merge before this one

@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 16, 2016
@david-mcmahon david-mcmahon added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 16, 2016
@luxas
Copy link
Member Author

luxas commented May 17, 2016

@k8s-oncall Mind merging manually?
This PR is required for the next alpha release, and now the tests seem to be unresponsive, so it doesn't reach the queue

@wojtek-t
Copy link
Member

@k8s-bot test this please github issue: #IGNORE (tests didn't started)

@wojtek-t wojtek-t added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels May 17, 2016
@k8s-bot
Copy link

k8s-bot commented May 17, 2016

GCE e2e build/test passed for commit e7eff87.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 1738bbf into kubernetes:master May 17, 2016
@peebs
Copy link

peebs commented Jun 30, 2016 •
edited
Loading

@luxas do you have more information on why or how hyperkube --make-symlinks fails? I introduced the command and I've successfully built hyperkube images using that dockerfile command above. I've also run the kubelet using the symlink entry point.

I've just tried to reproduce any issues with the symlinks using a cut of v1.3.0 that I made today and have not seen any issues.

I'd like to fix this I just don't know how to reproduce the issues right now.

@luxus
Copy link

luxus commented Jul 1, 2016

i think you mean @luxas 💃

@peebs peebs mentioned this pull request Jul 8, 2016
Closed
@peebs peebs mentioned this pull request Jul 26, 2016
Merged
k8s-github-robot pushed a commit that referenced this pull request Aug 2, 2016
Merge pull request #29591 from pbx0/symlinks
1ec1051 
Automatic merge from submit-queue

cluster/images/hyperkube: re-add hyperkube busybox style symlinks

Originally symlinks were added with a `--make-symlinks` command discussed in #24510 and implemented in #24511.

It was backed out in #25693 because go binaries don't run in qemu and this breaks cross-building the Dockerfile for arm. In this case, due to running `hyperkube --make-symlinks`.

Lets just add the symlinks manually until the upstream bug is fixed (qemu).

fixes #28702

@mikedanese @thockin @yifan-gu @euank
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@david-mcmahon david-mcmahon

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@luxas @david-mcmahon @wojtek-t @k8s-bot @k8s-github-robot @peebs @luxus @googlebot